| Message ID | 20220329114540.17140-2-tinghan.shen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add basic SoC support for mediatek mt8195 | expand |
Il 29/03/22 13:45, Tinghan Shen ha scritto: > Documentation/devicetree/bindings/mmc/mtk-sd.yaml > 54:81 error line too long (95 > 80 characters) (line-length) > I can't reproduce this error that you're getting... this commit is not necessary, as the .yamllint file in the kernel allows a maximum line-length of 110 characters. rules: line-length: # 80 chars should be enough, but don't fail if a line is longer max: 110 https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/.yamllint?h=next-20220329 Please drop this commit. > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
Hi Angelo, On Tue, 2022-03-29 at 14:47 +0200, AngeloGioacchino Del Regno wrote: > Il 29/03/22 13:45, Tinghan Shen ha scritto: > > Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > 54:81 error line too long (95 > 80 characters) (line-length) > > > > I can't reproduce this error that you're getting... this commit is not > necessary, as the .yamllint file in the kernel allows a maximum line-length > of 110 characters. > > rules: > line-length: > # 80 chars should be enough, but don't fail if a line is longer > max: 110 > > https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/.yamllint?h=next-20220329__;!!CTRNKA9wMg0ARbw!1L9icT80FdI9EYV81qRGpzbEvV1NFP_pwk8YABV0eIiRf2ppttnPlRfu5aXEUsxODiE$ > > > Please drop this commit. Thank you for your feedback. I figured out why I have this error... It's because I do the yamllint outside of the bindings folder and not specify the yamllint config file. I'll drop this at next version. Best regards, Tinghan > > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index 297ada03e3de..7032f7adf3ca 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -50,7 +50,8 @@ properties: - description: source clock (required). - description: HCLK which used for host (required). - description: independent source clock gate (required for MT2712). - - description: bus clock used for internal register access (required for MT2712 MSDC0/3). + - description: bus clock used for internal register access + (required for MT2712 MSDC0/3). - description: msdc subsys clock gate (required for MT8192). - description: peripheral bus clock gate (required for MT8192). - description: AXI bus clock gate (required for MT8192).
Documentation/devicetree/bindings/mmc/mtk-sd.yaml 54:81 error line too long (95 > 80 characters) (line-length) Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> --- Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)