diff mbox series

[v2] secilc: kernel policy language is infix

Message ID 20211212184944.8681-1-toiwoton@gmail.com (mailing list archive)
State Accepted
Commit 8243b3e8253c
Headers show
Series [v2] secilc: kernel policy language is infix | expand

Commit Message

Topi Miettinen Dec. 12, 2021, 6:49 p.m. UTC 
Prefix / Polish (CIL): and a b
Infix (KPL): a and b
Postfix / Reverse Polish: a b and

Signed-off-by: Topi Miettinen <toiwoton@gmail.com>
---
v2: improved commit message

v1: https://lore.kernel.org/selinux/20211119213728.19331-1-toiwoton@gmail.com/
---
 secilc/docs/cil_reference_guide.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: f7ec4b4a84aaf3e60b099e267dbfdabbfb1878c7

Comments

James Carter March 30, 2022, 5:33 p.m. UTC | #1 
On Sun, Dec 12, 2021 at 4:22 PM Topi Miettinen <toiwoton@gmail.com> wrote:
>
> Prefix / Polish (CIL): and a b
> Infix (KPL): a and b
> Postfix / Reverse Polish: a b and
>
> Signed-off-by: Topi Miettinen <toiwoton@gmail.com>

Sorry, this dropped off my radar.

Acked-by: James Carter <jwcart2@gmail.com>

> ---
> v2: improved commit message
>
> v1: https://lore.kernel.org/selinux/20211119213728.19331-1-toiwoton@gmail.com/
> ---
>  secilc/docs/cil_reference_guide.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/secilc/docs/cil_reference_guide.md b/secilc/docs/cil_reference_guide.md
> index 1e63e680..ac800b12 100644
> --- a/secilc/docs/cil_reference_guide.md
> +++ b/secilc/docs/cil_reference_guide.md
> @@ -189,7 +189,7 @@ Expressions
>
>  Expressions may occur in the following CIL statements: [`booleanif`](cil_conditional_statements.md#booleanif), [`tunableif`](cil_conditional_statements.md#tunableif), [`classpermissionset`](cil_class_and_permission_statements.md#classpermissionset), [`typeattributeset`](cil_type_statements.md#typeattributeset), [`roleattributeset`](cil_role_statements.md#roleattributeset), [`categoryset`](cil_mls_labeling_statements.md#categoryset), [`constrain`](cil_constraint_statements.md#constrain), [`mlsconstrain`](cil_constraint_statements.md#mlsconstrain), [`validatetrans`](cil_constraint_statements.md#validatetrans), [`mlsvalidatetrans`](cil_constraint_statements.md#mlsvalidatetrans)
>
> -CIL expressions use the [prefix](http://www.cs.man.ac.uk/~pjj/cs212/fix.html) or Polish notation and may be nested (note that the kernel policy language uses postfix or reverse Polish notation). The syntax is as follows, where the parenthesis are part of the syntax:
> +CIL expressions use the [prefix](http://www.cs.man.ac.uk/~pjj/cs212/fix.html) or Polish notation and may be nested (note that the kernel policy language uses infix notation). The syntax is as follows, where the parenthesis are part of the syntax:
>
>  ```
>      expr_set = (name ... | expr ...)
>
> base-commit: f7ec4b4a84aaf3e60b099e267dbfdabbfb1878c7
> --
> 2.33.0
>
James Carter March 30, 2022, 7:02 p.m. UTC | #2 
On Wed, Mar 30, 2022 at 1:33 PM James Carter <jwcart2@gmail.com> wrote:
>
> On Sun, Dec 12, 2021 at 4:22 PM Topi Miettinen <toiwoton@gmail.com> wrote:
> >
> > Prefix / Polish (CIL): and a b
> > Infix (KPL): a and b
> > Postfix / Reverse Polish: a b and
> >
> > Signed-off-by: Topi Miettinen <toiwoton@gmail.com>
>
> Sorry, this dropped off my radar.
>
> Acked-by: James Carter <jwcart2@gmail.com>
>

And merged.
Thanks,
Jim

> > ---
> > v2: improved commit message
> >
> > v1: https://lore.kernel.org/selinux/20211119213728.19331-1-toiwoton@gmail.com/
> > ---
> >  secilc/docs/cil_reference_guide.md | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/secilc/docs/cil_reference_guide.md b/secilc/docs/cil_reference_guide.md
> > index 1e63e680..ac800b12 100644
> > --- a/secilc/docs/cil_reference_guide.md
> > +++ b/secilc/docs/cil_reference_guide.md
> > @@ -189,7 +189,7 @@ Expressions
> >
> >  Expressions may occur in the following CIL statements: [`booleanif`](cil_conditional_statements.md#booleanif), [`tunableif`](cil_conditional_statements.md#tunableif), [`classpermissionset`](cil_class_and_permission_statements.md#classpermissionset), [`typeattributeset`](cil_type_statements.md#typeattributeset), [`roleattributeset`](cil_role_statements.md#roleattributeset), [`categoryset`](cil_mls_labeling_statements.md#categoryset), [`constrain`](cil_constraint_statements.md#constrain), [`mlsconstrain`](cil_constraint_statements.md#mlsconstrain), [`validatetrans`](cil_constraint_statements.md#validatetrans), [`mlsvalidatetrans`](cil_constraint_statements.md#mlsvalidatetrans)
> >
> > -CIL expressions use the [prefix](http://www.cs.man.ac.uk/~pjj/cs212/fix.html) or Polish notation and may be nested (note that the kernel policy language uses postfix or reverse Polish notation). The syntax is as follows, where the parenthesis are part of the syntax:
> > +CIL expressions use the [prefix](http://www.cs.man.ac.uk/~pjj/cs212/fix.html) or Polish notation and may be nested (note that the kernel policy language uses infix notation). The syntax is as follows, where the parenthesis are part of the syntax:
> >
> >  ```
> >      expr_set = (name ... | expr ...)
> >
> > base-commit: f7ec4b4a84aaf3e60b099e267dbfdabbfb1878c7
> > --
> > 2.33.0
> >
diff mbox series

Patch

diff --git a/secilc/docs/cil_reference_guide.md b/secilc/docs/cil_reference_guide.md
index 1e63e680..ac800b12 100644
--- a/secilc/docs/cil_reference_guide.md
+++ b/secilc/docs/cil_reference_guide.md
@@ -189,7 +189,7 @@  Expressions
 
 Expressions may occur in the following CIL statements: [`booleanif`](cil_conditional_statements.md#booleanif), [`tunableif`](cil_conditional_statements.md#tunableif), [`classpermissionset`](cil_class_and_permission_statements.md#classpermissionset), [`typeattributeset`](cil_type_statements.md#typeattributeset), [`roleattributeset`](cil_role_statements.md#roleattributeset), [`categoryset`](cil_mls_labeling_statements.md#categoryset), [`constrain`](cil_constraint_statements.md#constrain), [`mlsconstrain`](cil_constraint_statements.md#mlsconstrain), [`validatetrans`](cil_constraint_statements.md#validatetrans), [`mlsvalidatetrans`](cil_constraint_statements.md#mlsvalidatetrans)
 
-CIL expressions use the [prefix](http://www.cs.man.ac.uk/~pjj/cs212/fix.html) or Polish notation and may be nested (note that the kernel policy language uses postfix or reverse Polish notation). The syntax is as follows, where the parenthesis are part of the syntax:
+CIL expressions use the [prefix](http://www.cs.man.ac.uk/~pjj/cs212/fix.html) or Polish notation and may be nested (note that the kernel policy language uses infix notation). The syntax is as follows, where the parenthesis are part of the syntax:
 
 ```
     expr_set = (name ... | expr ...)