[00/12] drm/edid: cleanup and refactoring around validity checks

Message

Jani Nikula March 29, 2022, 6:42 p.m. UTC

Another day, another batch of EDID code refactoring.

Mostly the goal was to simplify drm_do_get_edid(), but trying to extract
a const function for checking a single block validity lead me down a
rabbit hole...

BR,
Jani.


Cc: Ville Syrjälä <[e-mail]>
Cc: Emil Velikov <[e-mail]>

Jani Nikula (12):
  drm/edid: use struct edid * in drm_do_get_edid()
  drm/edid: clean up EDID block checksum functions
  drm/edid: add edid_block_tag() helper to get the EDID extension tag
  drm/edid: make drm_edid_header_is_valid() accept void pointer
  drm/edid: clean up edid_is_zero()
  drm/edid: split out edid_header_fix()
  drm/edid: split drm_edid_block_valid() to check and act parts
  drm/edid: use a better variable name for EDID block read retries
  drm/edid: simplify block check when filtering invalid blocks
  drm/edid: split out invalid block filtering to a separate function
  drm/edid: track invalid blocks in drm_do_get_edid()
  drm/edid: reduce magic when updating the EDID block checksum

 drivers/gpu/drm/drm_edid.c | 293 +++++++++++++++++++++----------------
 include/drm/drm_edid.h     |   2 +-
 2 files changed, 171 insertions(+), 124 deletions(-)

Comments

Ville Syrjala March 31, 2022, 5:07 p.m. UTC | #1

On Tue, Mar 29, 2022 at 09:42:07PM +0300, Jani Nikula wrote:
> Another day, another batch of EDID code refactoring.
> 
> Mostly the goal was to simplify drm_do_get_edid(), but trying to extract
> a const function for checking a single block validity lead me down a
> rabbit hole...
> 
> BR,
> Jani.
> 
> 
> Cc: Ville Syrjälä <[e-mail]>
> Cc: Emil Velikov <[e-mail]>
> 
> Jani Nikula (12):
>   drm/edid: use struct edid * in drm_do_get_edid()
>   drm/edid: clean up EDID block checksum functions
>   drm/edid: add edid_block_tag() helper to get the EDID extension tag
>   drm/edid: make drm_edid_header_is_valid() accept void pointer
>   drm/edid: clean up edid_is_zero()
>   drm/edid: split out edid_header_fix()
>   drm/edid: split drm_edid_block_valid() to check and act parts
>   drm/edid: use a better variable name for EDID block read retries
>   drm/edid: simplify block check when filtering invalid blocks
>   drm/edid: split out invalid block filtering to a separate function
>   drm/edid: track invalid blocks in drm_do_get_edid()
>   drm/edid: reduce magic when updating the EDID block checksum

With the few bugs I spotted fixed the series is
Reviewed-by: Ville Syrjälä <[e-mail]>

> 
>  drivers/gpu/drm/drm_edid.c | 293 +++++++++++++++++++++----------------
>  include/drm/drm_edid.h     |   2 +-
>  2 files changed, 171 insertions(+), 124 deletions(-)
> 
> -- 
> 2.30.2