| Message ID | 20220401155610.1280262-1-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | modpost: restore the warning message for missing symbol versions | expand |
On Sat, Apr 02, 2022 at 12:56:10AM +0900, Masahiro Yamada wrote: > This log message was accidentally chopped off. Acked-by: Mark Brown <broonie@kernel.org>
On Fri, Apr 1, 2022 at 8:56 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > This log message was accidentally chopped off. > > I was wondering why this happened, but checking the ML log, Mark > precisely followed my suggestion [1]. > > I just used "..." because I was too lazy to type the sentence fully. > Sorry for the confusion. > > [1]: https://lore.kernel.org/all/CAK7LNAR6bXXk9-ZzZYpTqzFqdYbQsZHmiWspu27rtsFxvfRuVA@mail.gmail.com/ > > Fixes: 4a6795933a89 ("kbuild: modpost: Explicitly warn about unprototyped symbols") > Cc: Mark Brown <broonie@kernel.org> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > > scripts/mod/modpost.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index d10f93aac1c8..ed9d056d2108 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -674,7 +674,7 @@ static void handle_modversion(const struct module *mod, > unsigned int crc; > > if (sym->st_shndx == SHN_UNDEF) { > - warn("EXPORT symbol \"%s\" [%s%s] version ...\n" > + warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n" > "Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n", > symname, mod->name, mod->is_vmlinux ? "" : ".ko", > symname); > -- > 2.32.0 >
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index d10f93aac1c8..ed9d056d2108 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -674,7 +674,7 @@ static void handle_modversion(const struct module *mod, unsigned int crc; if (sym->st_shndx == SHN_UNDEF) { - warn("EXPORT symbol \"%s\" [%s%s] version ...\n" + warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n" "Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n", symname, mod->name, mod->is_vmlinux ? "" : ".ko", symname);
This log message was accidentally chopped off. I was wondering why this happened, but checking the ML log, Mark precisely followed my suggestion [1]. I just used "..." because I was too lazy to type the sentence fully. Sorry for the confusion. [1]: https://lore.kernel.org/all/CAK7LNAR6bXXk9-ZzZYpTqzFqdYbQsZHmiWspu27rtsFxvfRuVA@mail.gmail.com/ Fixes: 4a6795933a89 ("kbuild: modpost: Explicitly warn about unprototyped symbols") Cc: Mark Brown <broonie@kernel.org> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- scripts/mod/modpost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)