| Message ID | 20220403140202.2191516-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2baed4f9b085724a8a34add832d4763f3d83f877 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | stmmac: dwmac-loongson: change loongson_dwmac_driver from global to static | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Sun, 3 Apr 2022 10:02:02 -0400 you wrote: > Smatch reports this issue > dwmac-loongson.c:208:19: warning: symbol > 'loongson_dwmac_driver' was not declared. > Should it be static? > > loongson_dwmac_driver is only used in dwmac-loongson.c. > File scope variables used only in one file should > be static. Change loongson_dwmac_driver's > storage-class-specifier from global to static. > > [...] Here is the summary with links: - stmmac: dwmac-loongson: change loongson_dwmac_driver from global to static https://git.kernel.org/netdev/net/c/2baed4f9b085 You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index ecf759ee1c9f..017dbbda0c1c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -205,7 +205,7 @@ static const struct pci_device_id loongson_dwmac_id_table[] = { }; MODULE_DEVICE_TABLE(pci, loongson_dwmac_id_table); -struct pci_driver loongson_dwmac_driver = { +static struct pci_driver loongson_dwmac_driver = { .name = "dwmac-loongson-pci", .id_table = loongson_dwmac_id_table, .probe = loongson_dwmac_probe,
Smatch reports this issue dwmac-loongson.c:208:19: warning: symbol 'loongson_dwmac_driver' was not declared. Should it be static? loongson_dwmac_driver is only used in dwmac-loongson.c. File scope variables used only in one file should be static. Change loongson_dwmac_driver's storage-class-specifier from global to static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)