| Message ID | 20220404133904.1296258-1-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RZN1 DMA support | expand |
Hi Miquel, On Mon, Apr 4, 2022 at 3:39 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > Here is a first series bringing DMA support to RZN1 platforms. Soon a > second series will come with changes made to the UART controller > driver, in order to interact with the RZN1 DMA controller. > > Stephen acked the sysctrl patch (in the clk driver) but somehow I feel > like it would be good to have this patch applied on both sides > (dmaengine and clk) because more changes will depend on the addition of > this helper, that are not related to DMA at all. I'll let you folks > figure out what is best. > > Cheers, > Miquèl > > Changes in v6: > * Added Stephen's acks. Looks like you forgot to add the ack? > * Fixed an extra newline added in the middle of nowhere. > * Rebased on top of v5.18-rc1. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, geert@linux-m68k.org wrote on Mon, 4 Apr 2022 16:48:58 +0200: > Hi Miquel, > > On Mon, Apr 4, 2022 at 3:39 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > Here is a first series bringing DMA support to RZN1 platforms. Soon a > > second series will come with changes made to the UART controller > > driver, in order to interact with the RZN1 DMA controller. > > > > Stephen acked the sysctrl patch (in the clk driver) but somehow I feel > > like it would be good to have this patch applied on both sides > > (dmaengine and clk) because more changes will depend on the addition of > > this helper, that are not related to DMA at all. I'll let you folks > > figure out what is best. > > > > Cheers, > > Miquèl > > > > Changes in v6: > > * Added Stephen's acks. > > Looks like you forgot to add the ack? Mmmh .____. I have several series queued and I did apply Stephen's tag to the wrong patch without noticing. Kudos for catching this. I will send an updated version with it and Ilpo's comment addressed later this week. In the mean time if there is anything else, let me know. Thanks, Miquèl
Hello, Here is a first series bringing DMA support to RZN1 platforms. Soon a second series will come with changes made to the UART controller driver, in order to interact with the RZN1 DMA controller. Stephen acked the sysctrl patch (in the clk driver) but somehow I feel like it would be good to have this patch applied on both sides (dmaengine and clk) because more changes will depend on the addition of this helper, that are not related to DMA at all. I'll let you folks figure out what is best. Cheers, Miquèl Changes in v6: * Added Stephen's acks. * Fixed an extra newline added in the middle of nowhere. * Rebased on top of v5.18-rc1. Changes in v5: * Used gotos in rzn1_dmamux_route_allocate(). * Changed the prefix to "dmaengine:". * Dropped the partial transfers fix. * Added Rob's acks. Changes in v4: * Freed "map" in the error path of the dmamux driver. * Improved a bit the style as requested by Prabhakar. * Dropped a __maybe_unused. * Reorder the includes. * Added a dependency on ARCH_RZN1. * Added Rob's Ack. * Added a reg property to the dmamux binding file. * Referenced the dmamux binding from the system controller file. * Called of_platform_populate from the end of the system controller (clock) driver probe in order to probe the dmamux if it was populated. * Added DMA properties to all the relevant UARTs. Changes in v3: * Added Reviewed-by tags. * Exported the set_dmamux* symbol properly. * Dropped a useless check in the probe and moved the sysctrl_priv assignation to the end of the probe. * Renamed the dmamux driver * Added a couple of missing MODULE_ macros in the dmamux driver. * Decided to use a regular platform init call instead of the arch_initcall() initially proposed. * s/%d/%u/ in printk's when appropriate. * Used a hardcoded value instead of dmamux->dmac_requests when appropriate. * Changed the variable name "master" to "dmac_idx" to be more descriptive. * Dropped most of the of_* calls in favor of #define's. * Fixed a typo. * Exported two symbols from 8250_dma.c. Changes in v2: * Clarified that the 'fix' regarding non aligned reads would only apply to the DEV_TO_MEM case. * Fix the DMA controller compatible string (copy-paste error). * s/syscon/sysctrl/ as advised by Geert. * Disabled irqs when taking the spinlock from the clocks driver. * Moved the DMAMUX offset inside the driver. * Removed extra commas. * Improved the style as suggested by Andy. * Removed a dupplicated check against the device node presence. * Reduced the number of lines of code by using dev_err_probe(). * Created a Kconfig symbol for DMAMUX to fix the two robot reports received and be sure there was no useless overhead with other platforms. * Exported the serial8250_{tx,rx}_dma() symbols. Miquel Raynal (8): dt-bindings: dmaengine: Introduce RZN1 dmamux bindings dt-bindings: clock: r9a06g032-sysctrl: Reference the DMAMUX subnode dt-bindings: dmaengine: Introduce RZN1 DMA compatible soc: renesas: rzn1-sysc: Export function to set dmamux dmaengine: dw: dmamux: Introduce RZN1 DMA router support dmaengine: dw: Add RZN1 compatible ARM: dts: r9a06g032: Add the two DMA nodes ARM: dts: r9a06g032: Describe the DMA router .../clock/renesas,r9a06g032-sysctrl.yaml | 11 ++ .../bindings/dma/renesas,rzn1-dmamux.yaml | 51 ++++++ .../bindings/dma/snps,dma-spear1340.yaml | 8 +- MAINTAINERS | 1 + arch/arm/boot/dts/r9a06g032.dtsi | 40 +++++ drivers/clk/renesas/r9a06g032-clocks.c | 36 +++- drivers/dma/dw/Kconfig | 9 + drivers/dma/dw/Makefile | 2 + drivers/dma/dw/platform.c | 1 + drivers/dma/dw/rzn1-dmamux.c | 157 ++++++++++++++++++ include/linux/soc/renesas/r9a06g032-sysctrl.h | 11 ++ 11 files changed, 325 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/dma/renesas,rzn1-dmamux.yaml create mode 100644 drivers/dma/dw/rzn1-dmamux.c create mode 100644 include/linux/soc/renesas/r9a06g032-sysctrl.h