| Message ID | 20220401102002.15765-4-arinc.unal@arinc9.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] ARM: dts: BCM5301X: Fix DTC warning for NAND node | expand |
On 2022-04-01 12:20, Arınç ÜNAL wrote: > The et1macaddr NVRAM variable contains a MAC address for gmac1 on Asus > RT-AC88U. Add NVMEM cell for it and reference it in the gmac1 node. > > The Broadcom GBit BCMA driver will issue the MAC address for > gmac{0,1,2} > retrieved from et{0,1,2}mac from SPROM without this but let's > explicitly > define it as mac-address on the devicetree. > Refer to drivers/net/ethernet/broadcom/bgmac-bcma.c:147. It doesn't matter how Linux handles that in details. You're working on hardware binding. Change is OK of course. If you need to reference sth it should be Documentation/devicetree/bindings/net/ethernet-controller.yaml > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> I'd drop bgmac-bcma.c reference but nevertheless: Acked-by: Rafał Miłecki <rafal@milecki.pl>
On Fri, 1 Apr 2022 13:20:01 +0300, Arınç ÜNAL <arinc.unal@arinc9.com> wrote: > The et1macaddr NVRAM variable contains a MAC address for gmac1 on Asus > RT-AC88U. Add NVMEM cell for it and reference it in the gmac1 node. > > The Broadcom GBit BCMA driver will issue the MAC address for gmac{0,1,2} > retrieved from et{0,1,2}mac from SPROM without this but let's explicitly > define it as mac-address on the devicetree. > Refer to drivers/net/ethernet/broadcom/bgmac-bcma.c:147. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! -- Florian
diff --git a/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts b/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts index 5696dd5fbaf4..2f944d1c0330 100644 --- a/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts +++ b/arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts @@ -25,6 +25,9 @@ memory@0 { nvram@1c080000 { compatible = "brcm,nvram"; reg = <0x1c080000 0x00180000>; + + et1macaddr: et1macaddr { + }; }; leds { @@ -239,6 +242,11 @@ fixed-link { }; }; +&gmac1 { + nvmem-cells = <&et1macaddr>; + nvmem-cell-names = "mac-address"; +}; + &usb2 { vcc-gpio = <&chipcommon 9 GPIO_ACTIVE_HIGH>; };
The et1macaddr NVRAM variable contains a MAC address for gmac1 on Asus RT-AC88U. Add NVMEM cell for it and reference it in the gmac1 node. The Broadcom GBit BCMA driver will issue the MAC address for gmac{0,1,2} retrieved from et{0,1,2}mac from SPROM without this but let's explicitly define it as mac-address on the devicetree. Refer to drivers/net/ethernet/broadcom/bgmac-bcma.c:147. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- arch/arm/boot/dts/bcm47094-asus-rt-ac88u.dts | 8 ++++++++ 1 file changed, 8 insertions(+)