| Message ID | 1d15923b4ffb94531435c48482fef276a11b9a67.1648981531.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: mtk_scp: Fix a potential double free | expand |
Il 03/04/22 12:25, Christophe JAILLET ha scritto: > 'scp->rproc' is allocated using devm_rproc_alloc(), so there is no need > to free it explicitly in the remove function. > > Fixes: c1407ac1099a ("remoteproc: mtk_scp: Use devm variant of rproc_alloc()") Hello Cristophe, thanks for the patch! I agree with what you're doing here, but you forgot to add your Signed-off-by. Please resend it with your signoff, then I will give you my R-b. Also, please make sure to add me to the Ccs so that I can see your v2 sooner! Thanks, Angelo
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 38609153bf64..4a0e6c4bc6f4 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -877,7 +877,6 @@ static int scp_remove(struct platform_device *pdev) for (i = 0; i < SCP_IPI_MAX; i++) mutex_destroy(&scp->ipi_desc[i].lock); mutex_destroy(&scp->send_lock); - rproc_free(scp->rproc); return 0; }
'scp->rproc' is allocated using devm_rproc_alloc(), so there is no need to free it explicitly in the remove function. Fixes: c1407ac1099a ("remoteproc: mtk_scp: Use devm variant of rproc_alloc()") --- drivers/remoteproc/mtk_scp.c | 1 - 1 file changed, 1 deletion(-)