| Message ID | 20220406094654.29722-4-rex-bc.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Correct disp_aal dt-binding | expand |
Il 06/04/22 11:46, Rex-BC Chen ha scritto: > The driver data for MT8192 is the same with MT8183. Therefore, we > correct it. > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ...though, from what I know, you should also move MT8195 down there!
On Wed, 2022-04-06 at 18:40 +0800, AngeloGioacchino Del Regno wrote: > Il 06/04/22 11:46, Rex-BC Chen ha scritto: > > The driver data for MT8192 is the same with MT8183. Therefore, we > > correct it. > > > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > ...though, from what I know, you should also move MT8195 down there! Hello Angelo, Thanks for your review. But for MT8195, disp_aal is using the same compatible with MT8173. From the MT8195 project DTS is using: aal0: disp_aal@1c005000 { compatible = "mediatek,mt8195-disp-aal", "mediatek,mt8173-disp-aal"; reg = <0 0x1c005000 0 0x1000>; interrupts = <GIC_SPI 641 IRQ_TYPE_LEVEL_HIGH 0>; power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>; clocks = <&vdosys0 CLK_VDO0_DISP_AAL0>; mediatek,gce-client-reg = <&gce0 SUBSYS_1c00XXXX 0x5000 0x1000>; }; BRs, Rex
Il 06/04/22 12:48, Rex-BC Chen ha scritto: > On Wed, 2022-04-06 at 18:40 +0800, AngeloGioacchino Del Regno wrote: >> Il 06/04/22 11:46, Rex-BC Chen ha scritto: >>> The driver data for MT8192 is the same with MT8183. Therefore, we >>> correct it. >>> >>> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> >> >> Reviewed-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> >> ...though, from what I know, you should also move MT8195 down there! > > Hello Angelo, > > Thanks for your review. > But for MT8195, disp_aal is using the same compatible with MT8173. > > From the MT8195 project DTS is using: > > aal0: disp_aal@1c005000 { > compatible = "mediatek,mt8195-disp-aal", > "mediatek,mt8173-disp-aal"; > reg = <0 0x1c005000 0 0x1000>; > interrupts = <GIC_SPI 641 IRQ_TYPE_LEVEL_HIGH 0>; > power-domains = <&spm MT8195_POWER_DOMAIN_VDOSYS0>; > clocks = <&vdosys0 CLK_VDO0_DISP_AAL0>; > mediatek,gce-client-reg = > <&gce0 SUBSYS_1c00XXXX 0x5000 0x1000>; > }; > > BRs, > Rex > I'm sorry Rex, I've just realized - I was confusing this one with the 8195 gamma binding instead! Cheers, Angelo
On 06/04/2022 11:46, Rex-BC Chen wrote: > The driver data for MT8192 is the same with MT8183. Therefore, we > correct it. Driver data is Linux implementation specific so does not really matter for bindings. Probably you want to say here that devices are fully compatible? If so, please rephrase it. Also remove the wording "correct it" in subject and here because there is no mistake here (at least you did not describe it) and otherwise AUTOSEL might pick it up... Best regards, Krzysztof
On Wed, 2022-04-06 at 22:46 +0800, Krzysztof Kozlowski wrote: > On 06/04/2022 11:46, Rex-BC Chen wrote: > > The driver data for MT8192 is the same with MT8183. Therefore, we > > correct it. > > Driver data is Linux implementation specific so does not really > matter > for bindings. Probably you want to say here that devices are fully > compatible? If so, please rephrase it. Also remove the wording > "correct > it" in subject and here because there is no mistake here (at least > you > did not describe it) and otherwise AUTOSEL might pick it up... > > Best regards, > Krzysztof Hello Krzysztof, Thanks for your review. Yes, it's not a error for dt-binding. I will update the description in next version. BRs, Rex
On Wed, 2022-04-06 at 18:40 +0800, AngeloGioacchino Del Regno wrote: > Il 06/04/22 11:46, Rex-BC Chen ha scritto: > > The driver data for MT8192 is the same with MT8183. Therefore, we > > correct it. > > > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > ...though, from what I know, you should also move MT8195 down there! Hello Angelo, We have some misunderstanding for disp_aal of MT8195. The MT8195 has independent disp_gamma which is seperated from disp_aal since MT8173. Therefore, for MT8195, the disp_aal should be the same with MT8183. I have checked this with Jason-JH Lin who is drm owner of MT8195. I will update disp_aal binding in next version. BRs, Rex
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml index f118075e4a89..407d7cbd6240 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml @@ -27,12 +27,12 @@ properties: - items: - enum: - mediatek,mt2712-disp-aal - - mediatek,mt8192-disp-aal - mediatek,mt8195-disp-aal - const: mediatek,mt8173-disp-aal - items: - enum: - mediatek,mt8186-disp-aal + - mediatek,mt8192-disp-aal - const: mediatek,mt8183-disp-aal reg:
The driver data for MT8192 is the same with MT8183. Therefore, we correct it. Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> --- .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)