| Message ID | 20220405114505.24389-3-garrit@slashdev.space (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bisect.c: remove unused includes | expand |
On Tue, Apr 05 2022, Garrit Franke wrote:
> Remove include "hash-lookup.h".
Like your 3/4 it would be nice to have a "orphaned since xyz", or was it
never used etc?
In these cases unlike most such C changes the compiler isn't of much use
for validation (we might be including this implicitly), so an
explanation saying why is helpful.
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > On Tue, Apr 05 2022, Garrit Franke wrote: > >> Remove include "hash-lookup.h". > > Like your 3/4 it would be nice to have a "orphaned since xyz", or was it > never used etc? > > In these cases unlike most such C changes the compiler isn't of much use > for validation (we might be including this implicitly), so an > explanation saying why is helpful. Thanks for pointing it out. I found the lack of explanation in some but not all of the changes disturbing.
diff --git a/bisect.c b/bisect.c index 9e6a2b7f20..1aced76257 100644 --- a/bisect.c +++ b/bisect.c @@ -6,7 +6,6 @@ #include "refs.h" #include "list-objects.h" #include "quote.h" -#include "hash-lookup.h" #include "run-command.h" #include "log-tree.h" #include "bisect.h"
Remove include "hash-lookup.h". Signed-off-by: Garrit Franke <garrit@slashdev.space> --- bisect.c | 1 - 1 file changed, 1 deletion(-)