| Message ID | 1649229362-31183-1-git-send-email-quic_vnivarth@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold | expand |
Hi, On Wed, Apr 6, 2022 at 12:16 AM Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> wrote: > > WLAN rail was leaking power during RBSC/sleep even after turning BT off. > Change sleep pinctrl configuration to handle same. > > --- > v3: apply same change to active state and other sc7280*.dts* as well > v2: used bias-bus-hold as per review comments > v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only > --- > > Vijaya Krishna Nivarthi (3): > arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold > arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold > arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold > > arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts | 12 ++++++------ > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 12 ++++++------ > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 13 ++++++++----- > 3 files changed, 20 insertions(+), 17 deletions(-) Probably the subject of all the patches should be modified to talk about what each patch is applying to. Having 3 identically named patches is not ideal. I'll let Bjorn chime in on whether he'd rather adjust the subject himself or whether he'd rather you re-send. In any case, with the subject modified then for all 3 patches: Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Wed 06 Apr 10:04 CDT 2022, Doug Anderson wrote: > Hi, > > On Wed, Apr 6, 2022 at 12:16 AM Vijaya Krishna Nivarthi > <quic_vnivarth@quicinc.com> wrote: > > > > WLAN rail was leaking power during RBSC/sleep even after turning BT off. > > Change sleep pinctrl configuration to handle same. > > > > --- > > v3: apply same change to active state and other sc7280*.dts* as well > > v2: used bias-bus-hold as per review comments > > v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only > > --- > > > > Vijaya Krishna Nivarthi (3): > > arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold > > arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold > > arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold > > > > arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts | 12 ++++++------ > > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 12 ++++++------ > > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 13 ++++++++----- > > 3 files changed, 20 insertions(+), 17 deletions(-) > > Probably the subject of all the patches should be modified to talk > about what each patch is applying to. Having 3 identically named > patches is not ideal. > > I'll let Bjorn chime in on whether he'd rather adjust the subject > himself or whether he'd rather you re-send. In any case, with the > subject modified then for all 3 patches: > I've been fixing up a ton of these during the last few releases, so I think it's time that I stop doing that. Please resubmit this with subject prefixes that matches the existing git log for each change. > Reviewed-by: Douglas Anderson <dianders@chromium.org> Thanks, Bjorn