| Message ID | 2fd88e6119f62b968477ef9781abb1832d399fd6.camel@perches.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | rtw89: rtw89_ser: add const to struct state_ent and event_ent | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Thu, 2022-04-07 at 13:14 -0700, Joe Perches wrote: > Change the struct and the uses to const to reduce data. > > $ size drivers/net/wireless/realtek/rtw89/ser.o* (x86-64 defconfig w/ rtw89) > text data bss dec hex filename > 3741 8 0 3749 ea5 drivers/net/wireless/realtek/rtw89/ser.o.new > 3437 312 0 3749 ea5 drivers/net/wireless/realtek/rtw89/ser.o.old > > Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Ping-Ke Shih <pkshih@realtek.com> Thank you. > --- > drivers/net/wireless/realtek/rtw89/core.h | 4 ++-- > drivers/net/wireless/realtek/rtw89/ser.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h > index 771722132c53b..9bf56ce5ab43f 100644 > --- a/drivers/net/wireless/realtek/rtw89/core.h > +++ b/drivers/net/wireless/realtek/rtw89/core.h > @@ -2853,8 +2853,8 @@ struct rtw89_ser { > > struct work_struct ser_hdl_work; > struct delayed_work ser_alarm_work; > - struct state_ent *st_tbl; > - struct event_ent *ev_tbl; > + const struct state_ent *st_tbl; > + const struct event_ent *ev_tbl; > struct list_head msg_q; > spinlock_t msg_q_lock; /* lock when read/write ser msg */ > DECLARE_BITMAP(flags, RTW89_NUM_OF_SER_FLAGS); > diff --git a/drivers/net/wireless/realtek/rtw89/ser.c b/drivers/net/wireless/realtek/rtw89/ser.c > index 837cdc366a61a..7fbda7ef96bbb 100644 > --- a/drivers/net/wireless/realtek/rtw89/ser.c > +++ b/drivers/net/wireless/realtek/rtw89/ser.c > @@ -396,7 +396,7 @@ static void ser_l2_reset_st_hdl(struct rtw89_ser *ser, u8 evt) > } > } > > -static struct event_ent ser_ev_tbl[] = { > +static const struct event_ent ser_ev_tbl[] = { > {SER_EV_NONE, "SER_EV_NONE"}, > {SER_EV_STATE_IN, "SER_EV_STATE_IN"}, > {SER_EV_STATE_OUT, "SER_EV_STATE_OUT"}, > @@ -412,7 +412,7 @@ static struct event_ent ser_ev_tbl[] = { > {SER_EV_MAXX, "SER_EV_MAX"} > }; > > -static struct state_ent ser_st_tbl[] = { > +static const struct state_ent ser_st_tbl[] = { > {SER_IDLE_ST, "SER_IDLE_ST", ser_idle_st_hdl}, > {SER_RESET_TRX_ST, "SER_RESET_TRX_ST", ser_reset_trx_st_hdl}, > {SER_DO_HCI_ST, "SER_DO_HCI_ST", ser_do_hci_st_hdl}, > > > ------Please consider the environment before printing this e-mail.
Joe Perches <joe@perches.com> wrote: > Change the struct and the uses to const to reduce data. > > $ size drivers/net/wireless/realtek/rtw89/ser.o* (x86-64 defconfig w/ rtw89) > text data bss dec hex filename > 3741 8 0 3749 ea5 drivers/net/wireless/realtek/rtw89/ser.o.new > 3437 312 0 3749 ea5 drivers/net/wireless/realtek/rtw89/ser.o.old > > Signed-off-by: Joe Perches <joe@perches.com> > Acked-by: Ping-Ke Shih <pkshih@realtek.com> Patch applied to wireless-next.git, thanks. af5175acc8e2 rtw89: rtw89_ser: add const to struct state_ent and event_ent
diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h index 771722132c53b..9bf56ce5ab43f 100644 --- a/drivers/net/wireless/realtek/rtw89/core.h +++ b/drivers/net/wireless/realtek/rtw89/core.h @@ -2853,8 +2853,8 @@ struct rtw89_ser { struct work_struct ser_hdl_work; struct delayed_work ser_alarm_work; - struct state_ent *st_tbl; - struct event_ent *ev_tbl; + const struct state_ent *st_tbl; + const struct event_ent *ev_tbl; struct list_head msg_q; spinlock_t msg_q_lock; /* lock when read/write ser msg */ DECLARE_BITMAP(flags, RTW89_NUM_OF_SER_FLAGS); diff --git a/drivers/net/wireless/realtek/rtw89/ser.c b/drivers/net/wireless/realtek/rtw89/ser.c index 837cdc366a61a..7fbda7ef96bbb 100644 --- a/drivers/net/wireless/realtek/rtw89/ser.c +++ b/drivers/net/wireless/realtek/rtw89/ser.c @@ -396,7 +396,7 @@ static void ser_l2_reset_st_hdl(struct rtw89_ser *ser, u8 evt) } } -static struct event_ent ser_ev_tbl[] = { +static const struct event_ent ser_ev_tbl[] = { {SER_EV_NONE, "SER_EV_NONE"}, {SER_EV_STATE_IN, "SER_EV_STATE_IN"}, {SER_EV_STATE_OUT, "SER_EV_STATE_OUT"}, @@ -412,7 +412,7 @@ static struct event_ent ser_ev_tbl[] = { {SER_EV_MAXX, "SER_EV_MAX"} }; -static struct state_ent ser_st_tbl[] = { +static const struct state_ent ser_st_tbl[] = { {SER_IDLE_ST, "SER_IDLE_ST", ser_idle_st_hdl}, {SER_RESET_TRX_ST, "SER_RESET_TRX_ST", ser_reset_trx_st_hdl}, {SER_DO_HCI_ST, "SER_DO_HCI_ST", ser_do_hci_st_hdl},
Change the struct and the uses to const to reduce data. $ size drivers/net/wireless/realtek/rtw89/ser.o* (x86-64 defconfig w/ rtw89) text data bss dec hex filename 3741 8 0 3749 ea5 drivers/net/wireless/realtek/rtw89/ser.o.new 3437 312 0 3749 ea5 drivers/net/wireless/realtek/rtw89/ser.o.old Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/wireless/realtek/rtw89/core.h | 4 ++-- drivers/net/wireless/realtek/rtw89/ser.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)