| Message ID | RHPEoHDkl9-X9DzB2A9P1Z-EowLK-VscTXgVAorSBWFb6yqJY585bMsVSe8otaj4Ahb9ng-CK5jnTt0wlhY_K1DPV3hRf7xg7pZa0mLgxy0=@protonmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for MSM8996 Pro | expand |
On Fri 08 Apr 23:18 CDT 2022, Yassine Oudjana wrote: > Add a qcom,msm8996pro compatible and move xiaomi,scorpio to the > same items list as it. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 129cdd246223..dcf2e0102857 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -186,7 +186,12 @@ properties: > - sony,kagura-row > - sony,keyaki-row > - xiaomi,gemini > + - const: qcom,msm8996 > + > + - items: > + - enum: > - xiaomi,scorpio > + - const: qcom,msm8996pro > - const: qcom,msm8996 So we want both platform compatibles in there? > > - items: > -- > 2.35.1 >
------- Original Message ------- On Tuesday, April 12th, 2022 at 11:30 PM, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > On Fri 08 Apr 23:18 CDT 2022, Yassine Oudjana wrote: > > Add a qcom,msm8996pro compatible and move xiaomi,scorpio to the > > same items list as it. > > > > Signed-off-by: Yassine Oudjana y.oudjana@protonmail.com > > --- > > Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > > index 129cdd246223..dcf2e0102857 100644 > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > > @@ -186,7 +186,12 @@ properties: > > - sony,kagura-row > > - sony,keyaki-row > > - xiaomi,gemini > > + - const: qcom,msm8996 > > + > > + - items: > > + - enum: > > - xiaomi,scorpio > > + - const: qcom,msm8996pro > > - const: qcom,msm8996 > > > So we want both platform compatibles in there? Instead of adding qcom,msm8996pro to qcom-cpufreq-nvmem and cpufreq-dt-platdev, I kept qcom,msm8996 as a fallback since pro isn't too different from non-pro 8996 and should run mostly fine if treated as that. I'll remove it if you think it is better. > > > - items: > > -- > > 2.35.1
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 129cdd246223..dcf2e0102857 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -186,7 +186,12 @@ properties: - sony,kagura-row - sony,keyaki-row - xiaomi,gemini + - const: qcom,msm8996 + + - items: + - enum: - xiaomi,scorpio + - const: qcom,msm8996pro - const: qcom,msm8996 - items:
Add a qcom,msm8996pro compatible and move xiaomi,scorpio to the same items list as it. Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++ 1 file changed, 5 insertions(+) -- 2.35.1