| Message ID | 20220413160900.36271-1-tommaso.merciai@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] arm64: dts: imx8mm-evk: add pwm1/backlight support | expand |
Hello Tomasso, On 13.04.22 18:08, Tommaso Merciai wrote: > Add pwm1/backlight support nodes for imx8mm_evk board. > Align with u-boot dts > > References: > - https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/ > > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > --- > Changes since v1: > - Fix commit body > - Enable pwm, backlight > > Changes since v2: > - Remove status okay from pwm1,backlight (enable as default) > > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > index 6d67df7692f1..c50d2cc3ca71 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > @@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > enable-active-high; > }; > > + backlight: backlight { > + compatible = "pwm-backlight"; > + pwms = <&pwm1 0 5000000>; > + brightness-levels = <0 255>; > + num-interpolated-steps = <255>; > + default-brightness-level = <250>; > + }; > + > ir-receiver { > compatible = "gpio-ir-receiver"; > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; > @@ -395,6 +403,11 @@ &wdog1 { > status = "okay"; > }; > > +&pwm1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_backlight>; imx8mm.dtsi has &pwm1 { status = "disabled" }; Where is it enabled? > +}; > + > &iomuxc { > pinctrl_fec1: fec1grp { > fsl,pins = < > @@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp { > MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166 > >; > }; > + > + pinctrl_backlight: backlightgrp { > + fsl,pins = < > + MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06 > + >; > + }; > };
On Wed, Apr 13, 2022 at 06:31:34PM +0200, Ahmad Fatoum wrote: > Hello Tomasso, > > On 13.04.22 18:08, Tommaso Merciai wrote: > > Add pwm1/backlight support nodes for imx8mm_evk board. > > Align with u-boot dts > > > > References: > > - https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/ > > > > Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> > > --- > > Changes since v1: > > - Fix commit body > > - Enable pwm, backlight > > > > Changes since v2: > > - Remove status okay from pwm1,backlight (enable as default) > > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > index 6d67df7692f1..c50d2cc3ca71 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi > > @@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > > enable-active-high; > > }; > > > > + backlight: backlight { > > + compatible = "pwm-backlight"; > > + pwms = <&pwm1 0 5000000>; > > + brightness-levels = <0 255>; > > + num-interpolated-steps = <255>; > > + default-brightness-level = <250>; > > + }; > > + > > ir-receiver { > > compatible = "gpio-ir-receiver"; > > gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; > > @@ -395,6 +403,11 @@ &wdog1 { > > status = "okay"; > > }; > > > > +&pwm1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_backlight>; > > imx8mm.dtsi has &pwm1 { status = "disabled" }; > Where is it enabled? Hi Ahmad, Thanks for review, update in v4. Tommaso > > > +}; > > + > > &iomuxc { > > pinctrl_fec1: fec1grp { > > fsl,pins = < > > @@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp { > > MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166 > > >; > > }; > > + > > + pinctrl_backlight: backlightgrp { > > + fsl,pins = < > > + MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06 > > + >; > > + }; > > }; > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi index 6d67df7692f1..c50d2cc3ca71 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi @@ -59,6 +59,14 @@ reg_usdhc2_vmmc: regulator-usdhc2 { enable-active-high; }; + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&pwm1 0 5000000>; + brightness-levels = <0 255>; + num-interpolated-steps = <255>; + default-brightness-level = <250>; + }; + ir-receiver { compatible = "gpio-ir-receiver"; gpios = <&gpio1 13 GPIO_ACTIVE_LOW>; @@ -395,6 +403,11 @@ &wdog1 { status = "okay"; }; +&pwm1 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_backlight>; +}; + &iomuxc { pinctrl_fec1: fec1grp { fsl,pins = < @@ -549,4 +562,10 @@ pinctrl_wdog: wdoggrp { MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166 >; }; + + pinctrl_backlight: backlightgrp { + fsl,pins = < + MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT 0x06 + >; + }; };
Add pwm1/backlight support nodes for imx8mm_evk board. Align with u-boot dts References: - https://patchwork.ozlabs.org/project/uboot/patch/20220326111911.13720-9-tommaso.merciai@amarulasolutions.com/ Signed-off-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com> --- Changes since v1: - Fix commit body - Enable pwm, backlight Changes since v2: - Remove status okay from pwm1,backlight (enable as default) arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)