| Message ID | d9193539d7d079d70fc3480afb1b413f4694ddd1.1648833420.git.christophe.leroy@csgroup.eu (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: Prepare cleanup of powerpc's asm/prom.h | expand |
Hello! On 4/2/22 1:21 PM, Christophe Leroy wrote: > powerpc's asm/prom.h brings some headers that it doesn't > need itself. > > In order to clean it up, first add missing headers in > users of asm/prom.h I'm not seeing any headers added in this patch? > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > drivers/usb/core/hcd-pci.c | 1 - > drivers/usb/host/ohci-ppc-of.c | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c > index 8176bc81a635..f192925f74f7 100644 > --- a/drivers/usb/core/hcd-pci.c > +++ b/drivers/usb/core/hcd-pci.c > @@ -15,7 +15,6 @@ > #ifdef CONFIG_PPC_PMAC > #include <asm/machdep.h> > #include <asm/pmac_feature.h> > -#include <asm/prom.h> > #endif > > #include "usb.h" > diff --git a/drivers/usb/host/ohci-ppc-of.c b/drivers/usb/host/ohci-ppc-of.c > index 45f7cceb6df3..1960b8dfdba5 100644 > --- a/drivers/usb/host/ohci-ppc-of.c > +++ b/drivers/usb/host/ohci-ppc-of.c > @@ -19,9 +19,6 @@ > #include <linux/of_irq.h> > #include <linux/of_platform.h> > > -#include <asm/prom.h> > - > - > static int > ohci_ppc_of_start(struct usb_hcd *hcd) > { MBR, Sergey
Le 03/04/2022 à 10:50, Sergey Shtylyov a écrit : > Hello! > > On 4/2/22 1:21 PM, Christophe Leroy wrote: > >> powerpc's asm/prom.h brings some headers that it doesn't >> need itself. >> >> In order to clean it up, first add missing headers in >> users of asm/prom.h > > I'm not seeing any headers added in this patch? You are right, my description is a bit of a shortcut. I'll send v2 with a more detailed description. Thanks Christophe > >> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> >> --- >> drivers/usb/core/hcd-pci.c | 1 - >> drivers/usb/host/ohci-ppc-of.c | 3 --- >> 2 files changed, 4 deletions(-) >> >> diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c >> index 8176bc81a635..f192925f74f7 100644 >> --- a/drivers/usb/core/hcd-pci.c >> +++ b/drivers/usb/core/hcd-pci.c >> @@ -15,7 +15,6 @@ >> #ifdef CONFIG_PPC_PMAC >> #include <asm/machdep.h> >> #include <asm/pmac_feature.h> >> -#include <asm/prom.h> >> #endif >> >> #include "usb.h" >> diff --git a/drivers/usb/host/ohci-ppc-of.c b/drivers/usb/host/ohci-ppc-of.c >> index 45f7cceb6df3..1960b8dfdba5 100644 >> --- a/drivers/usb/host/ohci-ppc-of.c >> +++ b/drivers/usb/host/ohci-ppc-of.c >> @@ -19,9 +19,6 @@ >> #include <linux/of_irq.h> >> #include <linux/of_platform.h> >> >> -#include <asm/prom.h> >> - >> - >> static int >> ohci_ppc_of_start(struct usb_hcd *hcd) >> { > > MBR, Sergey
diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c index 8176bc81a635..f192925f74f7 100644 --- a/drivers/usb/core/hcd-pci.c +++ b/drivers/usb/core/hcd-pci.c @@ -15,7 +15,6 @@ #ifdef CONFIG_PPC_PMAC #include <asm/machdep.h> #include <asm/pmac_feature.h> -#include <asm/prom.h> #endif #include "usb.h" diff --git a/drivers/usb/host/ohci-ppc-of.c b/drivers/usb/host/ohci-ppc-of.c index 45f7cceb6df3..1960b8dfdba5 100644 --- a/drivers/usb/host/ohci-ppc-of.c +++ b/drivers/usb/host/ohci-ppc-of.c @@ -19,9 +19,6 @@ #include <linux/of_irq.h> #include <linux/of_platform.h> -#include <asm/prom.h> - - static int ohci_ppc_of_start(struct usb_hcd *hcd) {
powerpc's asm/prom.h brings some headers that it doesn't need itself. In order to clean it up, first add missing headers in users of asm/prom.h Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> --- drivers/usb/core/hcd-pci.c | 1 - drivers/usb/host/ohci-ppc-of.c | 3 --- 2 files changed, 4 deletions(-)