| Message ID | 20220416062504.19005-2-luizluca@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,1/2] dt-bindings: net: dsa: realtek: cleanup compatible strings | expand |
On 16/04/2022 09:25, Luiz Angelo Daros de Luca wrote: > There is no need to add new compatible strings for each new supported > chip version. The compatible string is used only to select the subdriver > (rtl8365mb.c or rtl8366rb). Once in the subdriver, it will detect the Might as well call the subdriver rtl8365mb like rtl8366rb since you're going to send a v2 anyway. Arınç
On Sat, Apr 16, 2022 at 03:25:04AM -0300, Luiz Angelo Daros de Luca wrote: > There is no need to add new compatible strings for each new supported > chip version. The compatible string is used only to select the subdriver > (rtl8365mb.c or rtl8366rb). Once in the subdriver, it will detect the > chip model by itself, ignoring which compatible string was used. > > Link: https://lore.kernel.org/netdev/20220414014055.m4wbmr7tdz6hsa3m@bang-olufsen.dk/ > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > --- Hi Luiz, I think it's great that you identified this early enough to remove the redundant compatible string before it hits an official release. Now we have well-defined semantics regarding the compatible strings, which is great :) Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk> > drivers/net/dsa/realtek/realtek-mdio.c | 1 - > drivers/net/dsa/realtek/realtek-smi.c | 4 ---- > 2 files changed, 5 deletions(-) > > diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c > index 31e1f100e48e..c58f49d558d2 100644 > --- a/drivers/net/dsa/realtek/realtek-mdio.c > +++ b/drivers/net/dsa/realtek/realtek-mdio.c > @@ -267,7 +267,6 @@ static const struct of_device_id realtek_mdio_of_match[] = { > #endif > #if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8365MB) > { .compatible = "realtek,rtl8365mb", .data = &rtl8365mb_variant, }, > - { .compatible = "realtek,rtl8367s", .data = &rtl8365mb_variant, }, > #endif > { /* sentinel */ }, > }; > diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c > index 6cec559c90ce..45992f79ec8d 100644 > --- a/drivers/net/dsa/realtek/realtek-smi.c > +++ b/drivers/net/dsa/realtek/realtek-smi.c > @@ -551,10 +551,6 @@ static const struct of_device_id realtek_smi_of_match[] = { > .compatible = "realtek,rtl8365mb", > .data = &rtl8365mb_variant, > }, > - { > - .compatible = "realtek,rtl8367s", > - .data = &rtl8365mb_variant, > - }, > #endif > { /* sentinel */ }, > }; > -- > 2.35.1 >
On Sat, Apr 16, 2022 at 11:07:24AM +0000, Alvin Šipraga wrote: > Reviewed-by: Alvin ┼áipraga <alsi@bang-olufsen.dk> Yikes, let me try that again... Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
On 4/15/2022 11:25 PM, Luiz Angelo Daros de Luca wrote: > There is no need to add new compatible strings for each new supported > chip version. The compatible string is used only to select the subdriver > (rtl8365mb.c or rtl8366rb). Once in the subdriver, it will detect the > chip model by itself, ignoring which compatible string was used. > > Link: https://lore.kernel.org/netdev/20220414014055.m4wbmr7tdz6hsa3m@bang-olufsen.dk/ > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c index 31e1f100e48e..c58f49d558d2 100644 --- a/drivers/net/dsa/realtek/realtek-mdio.c +++ b/drivers/net/dsa/realtek/realtek-mdio.c @@ -267,7 +267,6 @@ static const struct of_device_id realtek_mdio_of_match[] = { #endif #if IS_ENABLED(CONFIG_NET_DSA_REALTEK_RTL8365MB) { .compatible = "realtek,rtl8365mb", .data = &rtl8365mb_variant, }, - { .compatible = "realtek,rtl8367s", .data = &rtl8365mb_variant, }, #endif { /* sentinel */ }, }; diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c index 6cec559c90ce..45992f79ec8d 100644 --- a/drivers/net/dsa/realtek/realtek-smi.c +++ b/drivers/net/dsa/realtek/realtek-smi.c @@ -551,10 +551,6 @@ static const struct of_device_id realtek_smi_of_match[] = { .compatible = "realtek,rtl8365mb", .data = &rtl8365mb_variant, }, - { - .compatible = "realtek,rtl8367s", - .data = &rtl8365mb_variant, - }, #endif { /* sentinel */ }, };
There is no need to add new compatible strings for each new supported chip version. The compatible string is used only to select the subdriver (rtl8365mb.c or rtl8366rb). Once in the subdriver, it will detect the chip model by itself, ignoring which compatible string was used. Link: https://lore.kernel.org/netdev/20220414014055.m4wbmr7tdz6hsa3m@bang-olufsen.dk/ Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> --- drivers/net/dsa/realtek/realtek-mdio.c | 1 - drivers/net/dsa/realtek/realtek-smi.c | 4 ---- 2 files changed, 5 deletions(-)