mbox series

[0/2] fix some bugs in V3.X Synopsys EDAC DDR driver

Message ID 20220318111742.15730-1-sherry.sun@nxp.com (mailing list archive)
Headers show
Series fix some bugs in V3.X Synopsys EDAC DDR driver | expand

Message

Sherry Sun March 18, 2022, 11:17 a.m. UTC 
The two patches fix some issues for V3.X Synopsys EDAC DDR in synopsys_edac.c.
For the details, please check the patch commit log. This has been verified on
i.MX8MP platform.

Sherry Sun (2):
  EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR
  EDAC: synopsys: re-enable the interrupts in intr_handler for V3.X
    Synopsys EDAC DDR

 drivers/edac/synopsys_edac.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

Comments

Michal Simek March 18, 2022, 11:30 a.m. UTC | #1 
+Shubhrajyoti.

On 3/18/22 12:17, Sherry Sun wrote:
> The two patches fix some issues for V3.X Synopsys EDAC DDR in synopsys_edac.c.
> For the details, please check the patch commit log. This has been verified on
> i.MX8MP platform.
> 
> Sherry Sun (2):
>    EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR
>    EDAC: synopsys: re-enable the interrupts in intr_handler for V3.X
>      Synopsys EDAC DDR
> 
>   drivers/edac/synopsys_edac.c | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
>
Sherry Sun March 25, 2022, 1:28 a.m. UTC | #2 
Gentle ping...

> -----Original Message-----
> From: Sherry Sun
> Sent: 2022年3月18日 19:20
> To: bp@alien8.de; mchehab@kernel.org; michal.simek@xilinx.com;
> tony.luck@intel.com; james.morse@arm.com; rric@kernel.org
> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: [PATCH 0/2] fix some bugs in V3.X Synopsys EDAC DDR driver
> 
> The two patches fix some issues for V3.X Synopsys EDAC DDR in
> synopsys_edac.c.
> For the details, please check the patch commit log. This has been verified on
> i.MX8MP platform.
> 
> Sherry Sun (2):
>   EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR
>   EDAC: synopsys: re-enable the interrupts in intr_handler for V3.X
>     Synopsys EDAC DDR
> 
>  drivers/edac/synopsys_edac.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> --
> 2.17.1
Sherry Sun April 18, 2022, 2:27 a.m. UTC | #3 
Hi Borislav, do you have any comments regarding this patch set?

Best regards
Sherry
> -----Original Message-----
> From: Sherry Sun
> Sent: 2022年3月18日 19:20
> To: bp@alien8.de; mchehab@kernel.org; michal.simek@xilinx.com;
> tony.luck@intel.com; james.morse@arm.com; rric@kernel.org
> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: [PATCH 0/2] fix some bugs in V3.X Synopsys EDAC DDR driver
> 
> The two patches fix some issues for V3.X Synopsys EDAC DDR in
> synopsys_edac.c.
> For the details, please check the patch commit log. This has been verified on
> i.MX8MP platform.
> 
> Sherry Sun (2):
>   EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR
>   EDAC: synopsys: re-enable the interrupts in intr_handler for V3.X
>     Synopsys EDAC DDR
> 
>  drivers/edac/synopsys_edac.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> --
> 2.17.1
Borislav Petkov April 18, 2022, 8:34 a.m. UTC | #4 
On Mon, Apr 18, 2022 at 02:27:21AM +0000, Sherry Sun wrote:
> Hi Borislav, do you have any comments regarding this patch set?

Yes, for EDAC drivers which have designated maintainers, I usually wait
first for them to have a look. In this case, Michal.

Thx.
Sherry Sun April 18, 2022, 10:12 a.m. UTC | #5 
Hi Borislav, thanks for the info. Hi Michal, would you please help review the patch set? Thanks a lot!

Best regards
Sherry

> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: 2022年4月18日 16:35
> To: Sherry Sun <sherry.sun@nxp.com>; michal.simek@xilinx.com
> Cc: mchehab@kernel.org; tony.luck@intel.com; james.morse@arm.com;
> rric@kernel.org; linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH 0/2] fix some bugs in V3.X Synopsys EDAC DDR driver
> 
> On Mon, Apr 18, 2022 at 02:27:21AM +0000, Sherry Sun wrote:
> > Hi Borislav, do you have any comments regarding this patch set?
> 
> Yes, for EDAC drivers which have designated maintainers, I usually wait first
> for them to have a look. In this case, Michal.
> 
> Thx.
> 
> --
> Regards/Gruss,
>     Boris.
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeopl
> e.kernel.org%2Ftglx%2Fnotes-about-
> netiquette&amp;data=04%7C01%7Csherry.sun%40nxp.com%7Ccea2785e929
> f44e59a4b08da211652b6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C637858677007128155%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp
> ;sdata=d7zJS1kgETYnQXkBO4K3m1D5cvFlJ75BID%2B8Fjy8a0A%3D&amp;rese
> rved=0
Borislav Petkov April 18, 2022, 10:20 a.m. UTC | #6 
On Mon, Apr 18, 2022 at 10:12:14AM +0000, Sherry Sun wrote:
> Hi Borislav, thanks for the info.

You're welcome.

I'd appreciate it, though, if you do not top-post on public mailing
lists but reply underneath the text you're quoting, just like I did.

Thx.
Sherry Sun April 18, 2022, 10:26 a.m. UTC | #7 
> Subject: Re: [PATCH 0/2] fix some bugs in V3.X Synopsys EDAC DDR driver
> 
> On Mon, Apr 18, 2022 at 10:12:14AM +0000, Sherry Sun wrote:
> > Hi Borislav, thanks for the info.
> 
> You're welcome.
> 
> I'd appreciate it, though, if you do not top-post on public mailing lists but
> reply underneath the text you're quoting, just like I did.

Hi Borislav, sorry for the inconvenience, got it now. ^_^ 

Best regards
Sherry

> 
> Thx.
> 
> --
> Regards/Gruss,
>     Boris.
> 
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeopl
> e.kernel.org%2Ftglx%2Fnotes-about-
> netiquette&amp;data=04%7C01%7Csherry.sun%40nxp.com%7Cf6fc1ba92cd
> b48d974ee08da212503c1%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C637858740108440664%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL
> jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp
> ;sdata=aCaTdGQ5BR8uWgOOboJkR3rd5kbdB0Q2yCG7wLd%2BjL4%3D&amp;
> reserved=0
Shubhrajyoti Datta April 19, 2022, 3:34 p.m. UTC | #8 
> -----Original Message-----
> From: Michal Simek <michal.simek@xilinx.com>
> Sent: Friday, March 18, 2022 5:00 PM
> To: Sherry Sun <sherry.sun@nxp.com>; bp@alien8.de;
> mchehab@kernel.org; Michal Simek <michals@xilinx.com>;
> tony.luck@intel.com; james.morse@arm.com; rric@kernel.org;
> Shubhrajyoti Datta <shubhraj@xilinx.com>
> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-imx@nxp.com
> Subject: Re: [PATCH 0/2] fix some bugs in V3.X Synopsys EDAC DDR driver
> 
> +Shubhrajyoti.
> 
> On 3/18/22 12:17, Sherry Sun wrote:
> > The two patches fix some issues for V3.X Synopsys EDAC DDR in
> synopsys_edac.c.
> > For the details, please check the patch commit log. This has been
> > verified on i.MX8MP platform.
> >
The changes look good to me .

Reviewed-by: Shubhrajyoti Datta <Shubhrajyoti.datta@xilinx.com>

> > Sherry Sun (2):
> >    EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR
> >    EDAC: synopsys: re-enable the interrupts in intr_handler for V3.X
> >      Synopsys EDAC DDR
> >
> >   drivers/edac/synopsys_edac.c | 11 +++++++++--
> >   1 file changed, 9 insertions(+), 2 deletions(-)
> >