| Message ID | 20220412033526.369115-1-zack@kde.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/ttm: Introduce TTM res manager debugfs helpers | expand |
Hi Zack, Reviewed-by: Christian König <christian.koenig@amd.com> for the entire series. One nit pick is that I want to get rid of using ttm_manager_type() in drivers and use pointers to the members directly. But that's something for a later cleanup anyway. Thanks, Christian. Am 12.04.22 um 05:35 schrieb Zack Rusin: > From: Zack Rusin <zackr@vmware.com> > > v2: Switch to using ttm_resource_manager's directly in the debugfs > callbacks > > This series introduces generic TTM resource manager debugfs helpers and > refactors TTM drivers which have been using hand rolled out versions > of those to use the new code. > > Zack Rusin (5): > drm/ttm: Add common debugfs code for resource managers > drm/vmwgfx: Add debugfs entries for various ttm resource managers > drm/amdgpu: Use TTM builtin resource manager debugfs code > drm/qxl: Use TTM builtin resource manager debugfs code > drm/radeon: Use TTM builtin resource manager debugfs code > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 86 +++++-------------------- > drivers/gpu/drm/qxl/qxl_ttm.c | 39 ++--------- > drivers/gpu/drm/radeon/radeon_ttm.c | 36 ++--------- > drivers/gpu/drm/ttm/ttm_resource.c | 34 ++++++++++ > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 18 ++++++ > include/drm/ttm/ttm_resource.h | 4 ++ > 6 files changed, 84 insertions(+), 133 deletions(-) >
On Tue, 2022-04-12 at 11:15 +0200, Christian König wrote: > > Hi Zack, > > Reviewed-by: Christian König <christian.koenig@amd.com> for the > entire > series. > > One nit pick is that I want to get rid of using ttm_manager_type() in > drivers and use pointers to the members directly. But that's > something > for a later cleanup anyway. That sounds good to me. Let me know if you'd like me to hold off on pushing this until the ttm_manager_type changes are ready, otherwise I'll push it to drm-misc-next tomorrow. z
Am 18.04.22 um 22:09 schrieb Zack Rusin: > On Tue, 2022-04-12 at 11:15 +0200, Christian König wrote: >> Hi Zack, >> >> Reviewed-by: Christian König <christian.koenig@amd.com> for the >> entire >> series. >> >> One nit pick is that I want to get rid of using ttm_manager_type() in >> drivers and use pointers to the members directly. But that's >> something >> for a later cleanup anyway. > That sounds good to me. Let me know if you'd like me to hold off on > pushing this until the ttm_manager_type changes are ready, otherwise > I'll push it to drm-misc-next tomorrow. Please go ahead with pushing. That's cleanup work which I will throw in when I have time (which rarely happens these days). Christian. > > z >
From: Zack Rusin <zackr@vmware.com> v2: Switch to using ttm_resource_manager's directly in the debugfs callbacks This series introduces generic TTM resource manager debugfs helpers and refactors TTM drivers which have been using hand rolled out versions of those to use the new code. Zack Rusin (5): drm/ttm: Add common debugfs code for resource managers drm/vmwgfx: Add debugfs entries for various ttm resource managers drm/amdgpu: Use TTM builtin resource manager debugfs code drm/qxl: Use TTM builtin resource manager debugfs code drm/radeon: Use TTM builtin resource manager debugfs code drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 86 +++++-------------------- drivers/gpu/drm/qxl/qxl_ttm.c | 39 ++--------- drivers/gpu/drm/radeon/radeon_ttm.c | 36 ++--------- drivers/gpu/drm/ttm/ttm_resource.c | 34 ++++++++++ drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 18 ++++++ include/drm/ttm/ttm_resource.h | 4 ++ 6 files changed, 84 insertions(+), 133 deletions(-)