| Message ID | 20220417132918.135795-1-zhangxuezhi1@coolpad.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/malidp: convert sysfs snprintf to sysfs_emit | expand |
On Sun, Apr 17, 2022 at 01:29:18PM +0000, Xuezhi Zhang wrote: > Fix the following coccicheck warning: > drivers/gpu/drm/arm/malidp_drv.c:658:8-16: > WARNING: use scnprintf or sprintf > > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> Thanks for this! Best regards, Liviu > --- > drivers/gpu/drm/arm/malidp_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > index d5aef21426cf..b1ffd5ba27d9 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -655,7 +655,7 @@ static ssize_t core_id_show(struct device *dev, struct device_attribute *attr, > struct drm_device *drm = dev_get_drvdata(dev); > struct malidp_drm *malidp = drm->dev_private; > > - return snprintf(buf, PAGE_SIZE, "%08x\n", malidp->core_id); > + return sysfs_emit(buf, "%08x\n", malidp->core_id); > } > > static DEVICE_ATTR_RO(core_id); > -- > 2.25.1 >
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c index d5aef21426cf..b1ffd5ba27d9 100644 --- a/drivers/gpu/drm/arm/malidp_drv.c +++ b/drivers/gpu/drm/arm/malidp_drv.c @@ -655,7 +655,7 @@ static ssize_t core_id_show(struct device *dev, struct device_attribute *attr, struct drm_device *drm = dev_get_drvdata(dev); struct malidp_drm *malidp = drm->dev_private; - return snprintf(buf, PAGE_SIZE, "%08x\n", malidp->core_id); + return sysfs_emit(buf, "%08x\n", malidp->core_id); } static DEVICE_ATTR_RO(core_id);
Fix the following coccicheck warning: drivers/gpu/drm/arm/malidp_drv.c:658:8-16: WARNING: use scnprintf or sprintf Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com> --- drivers/gpu/drm/arm/malidp_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)