Message ID | 20220419014056.2561750-1-lv.ruyi@zte.com.cn (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | net: ethernet: mtk_eth_soc: fix error check return value of debugfs_create_dir() | expand |
so sorry, please ignore the noise, I sent the mail to the wrong person. Thanks Lv Ruyi
On Tue, Apr 19, 2022 at 01:40:56AM +0000, cgel.zte@gmail.com wrote: > From: Lv Ruyi <lv.ruyi@zte.com.cn> > > If an error occurs, debugfs_create_file() will return ERR_PTR(-ERROR), > so use IS_ERR() to check it. > > Fixes: 804775dfc288 ("net: ethernet: mtk_eth_soc: add support for Wireless Ethernet Dispatch (WED)") > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> > --- > drivers/net/ethernet/mediatek/mtk_wed_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c b/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c > index a81d3fd1a439..0c284c18a8d7 100644 > --- a/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c > +++ b/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c > @@ -165,7 +165,7 @@ void mtk_wed_hw_add_debugfs(struct mtk_wed_hw *hw) > > snprintf(hw->dirname, sizeof(hw->dirname), "wed%d", hw->index); > dir = debugfs_create_dir(hw->dirname, NULL); > - if (!dir) > + if (IS_ERR(dir)) > return; You should not check the return value from any debugfs calls. If Zeal bot is saying you should, Zeal is broken/does not understand debugfs. Andrew
diff --git a/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c b/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c index a81d3fd1a439..0c284c18a8d7 100644 --- a/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c +++ b/drivers/net/ethernet/mediatek/mtk_wed_debugfs.c @@ -165,7 +165,7 @@ void mtk_wed_hw_add_debugfs(struct mtk_wed_hw *hw) snprintf(hw->dirname, sizeof(hw->dirname), "wed%d", hw->index); dir = debugfs_create_dir(hw->dirname, NULL); - if (!dir) + if (IS_ERR(dir)) return; hw->debugfs_dir = dir;