| Message ID | 20220419230340.2263545-1-kishen.maloor@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: fix bug in userspace PM APIs | expand |
On Tue, 19 Apr 2022, Kishen Maloor wrote: > This series fixes issue #267: > https://github.com/multipath-tcp/mptcp_net-next/issues/267 > > Specifically, calls to mptcp_token_get_sock() from userspace PM APIs > hold a reference to the msk which needs to be freed before leaving those > functions. This was causing a memory leak which was caught in > the CI debug build. > > Kishen Maloor (3): > Squash-to: mptcp: netlink: Add MPTCP_PM_CMD_ANNOUNCE > Squash-to: mptcp: netlink: Add MPTCP_PM_CMD_REMOVE > Squash-to: mptcp: netlink: allow userspace-driven subflow > establishment > > net/mptcp/pm_userspace.c | 93 +++++++++++++++++++++++----------------- > 1 file changed, 53 insertions(+), 40 deletions(-) > > > base-commit: e561667a821b0ecccba582520829f38da50567a3 > -- > 2.31.1 > > Thanks Kishen - patches are ready to squash unless the CI surprises us. Matthieu, I did run these in a virtme environment to confirm the leaks were fixed. The only remaining leak I saw was the upstream one (in msr_build_context()). -- Mat Martineau Intel
This series fixes issue #267: https://github.com/multipath-tcp/mptcp_net-next/issues/267 Specifically, calls to mptcp_token_get_sock() from userspace PM APIs hold a reference to the msk which needs to be freed before leaving those functions. This was causing a memory leak which was caught in the CI debug build. Kishen Maloor (3): Squash-to: mptcp: netlink: Add MPTCP_PM_CMD_ANNOUNCE Squash-to: mptcp: netlink: Add MPTCP_PM_CMD_REMOVE Squash-to: mptcp: netlink: allow userspace-driven subflow establishment net/mptcp/pm_userspace.c | 93 +++++++++++++++++++++++----------------- 1 file changed, 53 insertions(+), 40 deletions(-) base-commit: e561667a821b0ecccba582520829f38da50567a3 -- 2.31.1