| Message ID | 20220420030315.2575691-1-chi.minghao@zte.com.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b3598fe6d009b2f2144115dfc381615c8b534aec |
| Headers | show |
| Series | ASoC: SOF: using pm_runtime_resume_and_get to simplify the code | expand |
On 4/19/22 22:03, cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and > pm_runtime_put_noidle. This change is just to simplify the code, no > actual functional changes. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> Well, maybe that's a simplification, but we've been using the same pattern for years now. Is there really a clear direction to use this new function? the overwhelming majority of drivers in sound/soc still rely on the pm_runtime_get_sync (111 v. 7). > --- > sound/soc/sof/sof-client-probes.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/sound/soc/sof/sof-client-probes.c b/sound/soc/sof/sof-client-probes.c > index 797dedb26163..c4c6e03c8133 100644 > --- a/sound/soc/sof/sof-client-probes.c > +++ b/sound/soc/sof/sof-client-probes.c > @@ -503,10 +503,9 @@ static ssize_t sof_probes_dfs_points_read(struct file *file, char __user *to, > if (!buf) > return -ENOMEM; > > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0 && ret != -EACCES) { > dev_err_ratelimited(dev, "debugfs read failed to resume %d\n", ret); > - pm_runtime_put_noidle(dev); > goto exit; > } > > @@ -568,10 +567,9 @@ sof_probes_dfs_points_write(struct file *file, const char __user *from, > > desc = (struct sof_probe_point_desc *)tkns; > > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0 && ret != -EACCES) { > dev_err_ratelimited(dev, "debugfs write failed to resume %d\n", ret); > - pm_runtime_put_noidle(dev); > goto exit; > } > > @@ -621,10 +619,9 @@ sof_probes_dfs_points_remove_write(struct file *file, const char __user *from, > goto exit; > } > > - ret = pm_runtime_get_sync(dev); > + ret = pm_runtime_resume_and_get(dev); > if (ret < 0) { > dev_err_ratelimited(dev, "debugfs write failed to resume %d\n", ret); > - pm_runtime_put_noidle(dev); > goto exit; > } >
On Wed, Apr 20, 2022 at 08:28:31AM -0500, Pierre-Louis Bossart wrote: > On 4/19/22 22:03, cgel.zte@gmail.com wrote: > > From: Minghao Chi <chi.minghao@zte.com.cn> > > Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and > > pm_runtime_put_noidle. This change is just to simplify the code, no > > actual functional changes. > Well, maybe that's a simplification, but we've been using the same pattern for years now. > Is there really a clear direction to use this new function? It seems like a much better pattern and there's been a steady stream of conversion patches. The whole get/idle thing is pretty much just sharp edges. > the overwhelming majority of drivers in sound/soc still rely on the pm_runtime_get_sync (111 v. 7). We'll get there I'm sure.
On 4/20/22 10:23, Mark Brown wrote: > On Wed, Apr 20, 2022 at 08:28:31AM -0500, Pierre-Louis Bossart wrote: >> On 4/19/22 22:03, cgel.zte@gmail.com wrote: >>> From: Minghao Chi <chi.minghao@zte.com.cn> > >>> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and >>> pm_runtime_put_noidle. This change is just to simplify the code, no >>> actual functional changes. > >> Well, maybe that's a simplification, but we've been using the same pattern for years now. > >> Is there really a clear direction to use this new function? > > It seems like a much better pattern and there's been a steady stream of > conversion patches. The whole get/idle thing is pretty much just sharp > edges. > >> the overwhelming majority of drivers in sound/soc still rely on the pm_runtime_get_sync (111 v. 7). > > We'll get there I'm sure. ok, I'll send follow-up patches for the remaining code. For this patch: Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
On Wed, Apr 20, 2022 at 11:11:03AM -0500, Pierre-Louis Bossart wrote:
> ok, I'll send follow-up patches for the remaining code.
Thanks, like you say there's a lot to get through here!
On Wed, 20 Apr 2022 03:03:15 +0000, cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and > pm_runtime_put_noidle. This change is just to simplify the code, no > actual functional changes. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: SOF: using pm_runtime_resume_and_get to simplify the code commit: b3598fe6d009b2f2144115dfc381615c8b534aec All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/sof/sof-client-probes.c b/sound/soc/sof/sof-client-probes.c index 797dedb26163..c4c6e03c8133 100644 --- a/sound/soc/sof/sof-client-probes.c +++ b/sound/soc/sof/sof-client-probes.c @@ -503,10 +503,9 @@ static ssize_t sof_probes_dfs_points_read(struct file *file, char __user *to, if (!buf) return -ENOMEM; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0 && ret != -EACCES) { dev_err_ratelimited(dev, "debugfs read failed to resume %d\n", ret); - pm_runtime_put_noidle(dev); goto exit; } @@ -568,10 +567,9 @@ sof_probes_dfs_points_write(struct file *file, const char __user *from, desc = (struct sof_probe_point_desc *)tkns; - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0 && ret != -EACCES) { dev_err_ratelimited(dev, "debugfs write failed to resume %d\n", ret); - pm_runtime_put_noidle(dev); goto exit; } @@ -621,10 +619,9 @@ sof_probes_dfs_points_remove_write(struct file *file, const char __user *from, goto exit; } - ret = pm_runtime_get_sync(dev); + ret = pm_runtime_resume_and_get(dev); if (ret < 0) { dev_err_ratelimited(dev, "debugfs write failed to resume %d\n", ret); - pm_runtime_put_noidle(dev); goto exit; }