| Message ID | 20220414081916.11766-2-xiazhengqiao@huaqin.corp-partner.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND,v2,1/2] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel driver | expand |
On Thu, Apr 14, 2022 at 10:19 AM xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com> wrote: > Add dt-bindings for 10.1" TFT LCD module called STARRY 2081101 > QFH032011-53G. > > Signed-off-by: xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com> > Reviewed-by: Rob Herring <robh@kernel.org> (...) > + enable-gpios: > + description: a GPIO spec for the enable pin The way this is used in the code makes me suspect this should be named reset-gpios. What is the name of the pin on the panel? It also appears you should tag this as active low so in that case write that in the description "always tag with GPIO_ACTIVE_LOW" (and alter the code in the driver to match the inversion) > + pp1800-supply: > + description: core voltage supply Hm the name of this supply makes me think the display controller is actually named pp1800. Is this correct? > + enable-gpios = <&pio 45 0>; Don't use ordinal flags in examples. examples: - | #include <dt-bindings/gpio/gpio.h> (...) reset-gpios = <&gpio4 11 GPIO_ACTIVE_LOW>; Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/display/panel/innolux,himax8279d.yaml b/Documentation/devicetree/bindings/display/panel/innolux,himax8279d.yaml new file mode 100644 index 000000000000..fdcea3870dfb --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/innolux,himax8279d.yaml @@ -0,0 +1,72 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/innolux,himax8279d.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: INNOLUX HIMAX8279D DSI Display Panel + +maintainers: + - xiazhengqiao <xiazhengqiao@huaqin.corp-partner.google.com> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + enum: + # STARRY 2081101QFH032011-53G 10.1" WUXGA TFT LCD panel + - starry,2081101qfh032011-53g + + reg: + description: the virtual channel number of a DSI peripheral + + enable-gpios: + description: a GPIO spec for the enable pin + + pp1800-supply: + description: core voltage supply + + avdd-supply: + description: phandle of the regulator that provides positive voltage + + avee-supply: + description: phandle of the regulator that provides negative voltage + + backlight: + description: phandle of the backlight device attached to the panel + + port: true + +required: + - compatible + - reg + - enable-gpios + - pp1800-supply + - avdd-supply + - avee-supply + +additionalProperties: false + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "starry,2081101qfh032011-53g"; + reg = <0>; + enable-gpios = <&pio 45 0>; + avdd-supply = <&ppvarn_lcd>; + avee-supply = <&ppvarp_lcd>; + pp1800-supply = <&pp1800_lcd>; + backlight = <&backlight_lcd0>; + port { + panel_in: endpoint { + remote-endpoint = <&dsi_out>; + }; + }; + }; + }; + +...