| Message ID | 20220421044744.3777983-2-nava.manne@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fpga: fix for coding style and kernel-doc issues | expand |
On Thu, Apr 21, 2022 at 10:17:40AM +0530, Nava kishore Manne wrote: > zynq_fpga_has_sync () API is expecting "u8 *" but the > formal parameter that was passed is of type "const char *". > fixes this issue by changing the buf type to "const char *" Fix this issue by ... > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> With the minor fix, Acked-by: Xu Yilun <yilun.xu@intel.com> > --- > Changes for v2: > -None. > Changes for v3: > - Changed arg buf type to "const char *" as suggested by Tom. > - update zynq_fpga_has_sync () API description to align with API > functionality. > Changes for v4: > - None. > > Changes for v5: > - Dropped the irrelevant doc update changes. > > drivers/fpga/zynq-fpga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > index 426aa34c6a0d..6beaba9dfe97 100644 > --- a/drivers/fpga/zynq-fpga.c > +++ b/drivers/fpga/zynq-fpga.c > @@ -239,7 +239,7 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data) > * the correct byte order, and be dword aligned. The input is a Xilinx .bin > * file with every 32 bit quantity swapped. > */ > -static bool zynq_fpga_has_sync(const u8 *buf, size_t count) > +static bool zynq_fpga_has_sync(const char *buf, size_t count) > { > for (; count >= 4; buf += 4, count -= 4) > if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && > -- > 2.25.1
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 426aa34c6a0d..6beaba9dfe97 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -239,7 +239,7 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data) * the correct byte order, and be dword aligned. The input is a Xilinx .bin * file with every 32 bit quantity swapped. */ -static bool zynq_fpga_has_sync(const u8 *buf, size_t count) +static bool zynq_fpga_has_sync(const char *buf, size_t count) { for (; count >= 4; buf += 4, count -= 4) if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 &&
zynq_fpga_has_sync () API is expecting "u8 *" but the formal parameter that was passed is of type "const char *". fixes this issue by changing the buf type to "const char *" Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com> --- Changes for v2: -None. Changes for v3: - Changed arg buf type to "const char *" as suggested by Tom. - update zynq_fpga_has_sync () API description to align with API functionality. Changes for v4: - None. Changes for v5: - Dropped the irrelevant doc update changes. drivers/fpga/zynq-fpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)