[0/2] CI: don't fail OSX tests due to brew v.s. perforce.com mis-match

Message

Ævar Arnfjörð Bjarmason April 21, 2022, 12:53 p.m. UTC

Junio: Despite modifying CI stuff this series merges cleanly with
"seen", and has no semantic conflicts with any outstanding CI changes.

For the past days we've again had CI failures due to "brew install"
detecting a SHA-256 mismatch when trying to install the perforce
package[1]. E.g. "seen" is now failing: https://github.com/git/git/runs/6104156856?check_suite_focus=true

This occurrence of this issue will no doubt be fixed within a few days
as the homebrew-cask repository is updated, i.e. this recipe:
https://github.com/Homebrew/homebrew-cask/commits/master/Casks/perforce.rb

But for our CI usage being this anal about the check isn't worth it,
here's a passing CI run where we simply forced the installation:
https://github.com/avar/git/runs/6092916675?check_suite_focus=true#step:3:87
and subsequently passed the git-p4 tests:
https://github.com/avar/git/runs/6092916675?check_suite_focus=true#step:4:1678

Ævar Arnfjörð Bjarmason (2):
  CI: run "brew install perforce" without past workarounds
  CI: don't care about SHA256 mismatch on upstream "perforce" package

 ci/install-dependencies.sh | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Carlo Marcelo Arenas Belón April 21, 2022, 9:30 p.m. UTC | #1

On Thu, Apr 21, 2022 at 02:53:50PM +0200, Ævar Arnfjörð Bjarmason wrote:
> For the past days we've again had CI failures due to "brew install"
> detecting a SHA-256 mismatch when trying to install the perforce

Since the only reason why that is a concern is because it aborts the
rest of the run and is a recurring problem, wouldn't it be better to
tell the script to continue regardless and therefore skip all perforce
tests?

Sure, there is a window where that integration could be broken which
will be only visible once the perforce cask gets fixed and perforce
installs again, but wouldn't that be less intrusive and overall safer
than the currently proposed change?

Carlo

Junio C Hamano April 21, 2022, 9:39 p.m. UTC | #2

Carlo Marcelo Arenas Belón <[e-mail]> writes:

> On Thu, Apr 21, 2022 at 02:53:50PM +0200, Ævar Arnfjörð Bjarmason wrote:
>> For the past days we've again had CI failures due to "brew install"
>> detecting a SHA-256 mismatch when trying to install the perforce
>
> Since the only reason why that is a concern is because it aborts the
> rest of the run and is a recurring problem, wouldn't it be better to
> tell the script to continue regardless and therefore skip all perforce
> tests?
>
> Sure, there is a window where that integration could be broken which
> will be only visible once the perforce cask gets fixed and perforce
> installs again, but wouldn't that be less intrusive and overall safer
> than the currently proposed change?

Good suggestion.  Care to come up with an alternative patch (or
two)?

Thanks.

Junio C Hamano April 21, 2022, 9:57 p.m. UTC | #3

Ævar Arnfjörð Bjarmason  <[e-mail]> writes:

> Junio: Despite modifying CI stuff this series merges cleanly with
> "seen", and has no semantic conflicts with any outstanding CI changes.
>
> For the past days we've again had CI failures due to "brew install"
> detecting a SHA-256 mismatch when trying to install the perforce
> package[1]. E.g. "seen" is now failing: https://github.com/git/git/runs/6104156856?check_suite_focus=true

Yup, it was something I've been disturbed by and planning to ping
folks about if it continued.

> This occurrence of this issue will no doubt be fixed within a few days
> as the homebrew-cask repository is updated, i.e. this recipe:
> https://github.com/Homebrew/homebrew-cask/commits/master/Casks/perforce.rb
>
> But for our CI usage being this anal about the check isn't worth it,
> here's a passing CI run where we simply forced the installation:
> ...
> Ævar Arnfjörð Bjarmason (2):
>   CI: run "brew install perforce" without past workarounds
>   CI: don't care about SHA256 mismatch on upstream "perforce" package

I dunno.  Does it open us to a new attack vector in some way?

Ævar Arnfjörð Bjarmason April 22, 2022, 9:21 a.m. UTC | #4

On Thu, Apr 21 2022, Carlo Marcelo Arenas Belón wrote:

> On Thu, Apr 21, 2022 at 02:53:50PM +0200, Ævar Arnfjörð Bjarmason wrote:
>> For the past days we've again had CI failures due to "brew install"
>> detecting a SHA-256 mismatch when trying to install the perforce
>
> Since the only reason why that is a concern is because it aborts the
> rest of the run and is a recurring problem, wouldn't it be better to
> tell the script to continue regardless and therefore skip all perforce
> tests?
>
> Sure, there is a window where that integration could be broken which
> will be only visible once the perforce cask gets fixed and perforce
> installs again, but wouldn't that be less intrusive and overall safer
> than the currently proposed change?

I tried to answer all of this in the updated v3 CL. Thanks!:
https://lore.kernel.org/git/[e-mail]/