| Message ID | 20220421163128.101520-3-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | Add RZ/G2L Display support | expand |
Hi Biju, On Thu, Apr 21, 2022 at 6:31 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Fix typo rcar_du_vsp.h->rcar_du_vsp.c > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0+ > /* > - * rcar_du_vsp.h -- R-Car Display Unit VSP-Based Compositor > + * rcar_du_vsp.c -- R-Car Display Unit VSP-Based Compositor Perhaps drop the file name completely instead? > * > * Copyright (C) 2015 Renesas Electronics Corporation > * Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v3 2/4] drm: rcar-du: Fix typo > > Hi Biju, > > On Thu, Apr 21, 2022 at 6:31 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Fix typo rcar_du_vsp.h->rcar_du_vsp.c > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for your patch! > > > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > > @@ -1,6 +1,6 @@ > > // SPDX-License-Identifier: GPL-2.0+ > > /* > > - * rcar_du_vsp.h -- R-Car Display Unit VSP-Based Compositor > > + * rcar_du_vsp.c -- R-Car Display Unit VSP-Based Compositor > > Perhaps drop the file name completely instead? Currently all the R-Car DU files have file name. May be A single patch to remove all off them if we are planning to do. Laurent, please share your thoughts on this. Cheers, Biju
Hello, On Fri, Apr 22, 2022 at 09:38:00AM +0000, Biju Das wrote: > > Subject: Re: [PATCH v3 2/4] drm: rcar-du: Fix typo > > On Thu, Apr 21, 2022 at 6:31 PM Biju Das wrote: > > > Fix typo rcar_du_vsp.h->rcar_du_vsp.c > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > Thanks for your patch! > > > > > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > > > @@ -1,6 +1,6 @@ > > > // SPDX-License-Identifier: GPL-2.0+ > > > /* > > > - * rcar_du_vsp.h -- R-Car Display Unit VSP-Based Compositor > > > + * rcar_du_vsp.c -- R-Car Display Unit VSP-Based Compositor > > > > Perhaps drop the file name completely instead? > > Currently all the R-Car DU files have file name. May be > A single patch to remove all off them if we are planning to do. > > Laurent, please share your thoughts on this. Geert has a point, the file names cause issues and don't add much value. Would you like to send a patch to drop them all, to replace this one ? I can also handle it myself if you prefer.
Hi Laurent, > Subject: Re: [PATCH v3 2/4] drm: rcar-du: Fix typo > > Hello, > > On Fri, Apr 22, 2022 at 09:38:00AM +0000, Biju Das wrote: > > > Subject: Re: [PATCH v3 2/4] drm: rcar-du: Fix typo On Thu, Apr 21, > > > 2022 at 6:31 PM Biju Das wrote: > > > > Fix typo rcar_du_vsp.h->rcar_du_vsp.c > > > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > > > Thanks for your patch! > > > > > > > --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > > > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c > > > > @@ -1,6 +1,6 @@ > > > > // SPDX-License-Identifier: GPL-2.0+ > > > > /* > > > > - * rcar_du_vsp.h -- R-Car Display Unit VSP-Based Compositor > > > > + * rcar_du_vsp.c -- R-Car Display Unit VSP-Based Compositor > > > > > > Perhaps drop the file name completely instead? > > > > Currently all the R-Car DU files have file name. May be A single patch > > to remove all off them if we are planning to do. > > > > Laurent, please share your thoughts on this. > > Geert has a point, the file names cause issues and don't add much value. > Would you like to send a patch to drop them all, to replace this one ? I > can also handle it myself if you prefer. OK, I don't have any preference. I Just noticed that issue. Feel free to post the patch. Cheers, Biju
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 8eb9b2b097ae..9c4d1d1be1d4 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * rcar_du_vsp.h -- R-Car Display Unit VSP-Based Compositor + * rcar_du_vsp.c -- R-Car Display Unit VSP-Based Compositor * * Copyright (C) 2015 Renesas Electronics Corporation *
Fix typo rcar_du_vsp.h->rcar_du_vsp.c Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v3: * New patch --- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)