[v11,2/9] dt-bindings: clock: r9a06g032-sysctrl: Reference the DMAMUX subnode

Commit Message

Miquel Raynal April 21, 2022, 8:51 a.m. UTC

This system controller contains several registers that have nothing to
do with the clock handling, like the DMA mux register. Describe this
part of the system controller as a subnode.

Signed-off-by: Miquel Raynal <[e-mail]>
Reviewed-by: Rob Herring <[e-mail]>
Acked-by: Stephen Boyd <[e-mail]>
---
 .../bindings/clock/renesas,r9a06g032-sysctrl.yaml     | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Geert Uytterhoeven April 25, 2022, 4:08 p.m. UTC | #1

On Thu, Apr 21, 2022 at 10:51 AM Miquel Raynal
<[e-mail]> wrote:
> This system controller contains several registers that have nothing to
> do with the clock handling, like the DMA mux register. Describe this
> part of the system controller as a subnode.
>
> Signed-off-by: Miquel Raynal <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>
> Acked-by: Stephen Boyd <[e-mail]>

Reviewed-by: Geert Uytterhoeven <[e-mail]>

> --- a/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
> +++ b/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
> @@ -39,6 +39,17 @@ properties:
>    '#power-domain-cells':
>      const: 0
>
> +  '#address-cells':
> +    const: 1
> +
> +  '#size-cells':
> +    const: 1
> +
> +patternProperties:
> +  "^dma-router@[a-f0-9]+$":

For now this must be @a0, right?

> +    type: object
> +    $ref: "../dma/renesas,rzn1-dmamux.yaml#"
> +
>  required:
>    - compatible
>    - reg

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Miquel Raynal April 27, 2022, 8:49 a.m. UTC | #2

Hi Geert,

[e-mail] wrote on Mon, 25 Apr 2022 18:08:19 +0200:

> On Thu, Apr 21, 2022 at 10:51 AM Miquel Raynal
> <[e-mail]> wrote:
> > This system controller contains several registers that have nothing to
> > do with the clock handling, like the DMA mux register. Describe this
> > part of the system controller as a subnode.
> >
> > Signed-off-by: Miquel Raynal <[e-mail]>
> > Reviewed-by: Rob Herring <[e-mail]>
> > Acked-by: Stephen Boyd <[e-mail]>  
> 
> Reviewed-by: Geert Uytterhoeven <[e-mail]>

Thanks for all the feedback received so far!

> > --- a/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
> > +++ b/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
> > @@ -39,6 +39,17 @@ properties:
> >    '#power-domain-cells':
> >      const: 0
> >
> > +  '#address-cells':
> > +    const: 1
> > +
> > +  '#size-cells':
> > +    const: 1
> > +
> > +patternProperties:
> > +  "^dma-router@[a-f0-9]+$":  
> 
> For now this must be @a0, right?

Yes!

Cheers,
Miquèl

Patch

diff --git a/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml b/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
index 25dbb0fac065..95bf485c6cec 100644
--- a/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
+++ b/Documentation/devicetree/bindings/clock/renesas,r9a06g032-sysctrl.yaml
@@ -39,6 +39,17 @@  properties:
   '#power-domain-cells':
     const: 0
 
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 1
+
+patternProperties:
+  "^dma-router@[a-f0-9]+$":
+    type: object
+    $ref: "../dma/renesas,rzn1-dmamux.yaml#"
+
 required:
   - compatible
   - reg