[5.10.y-cip,00/24] Add sound support to Renesas RZ/G2L SoC

Message ID	20220420213424.27837-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
Headers	show Return-Path: <prabhakar.mahadev-lad.rj@bp.renesas.com> ip: 210.160.252.172, mailfrom: prabhakar.mahadev-lad.rj@bp.renesas.com) From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> To: cip-dev@lists.cip-project.org, Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>, Pavel Machek <pavel@denx.de> Cc: Biju Das <biju.das.jz@bp.renesas.com> Subject: [PATCH 5.10.y-cip 00/24] Add sound support to Renesas RZ/G2L SoC Date: Wed, 20 Apr 2022 22:34:00 +0100 Message-Id: <20220420213424.27837-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
Series	Add sound support to Renesas RZ/G2L SoC \| expand [5.10.y-cip,00/24] Add sound support to Renesas RZ/G2L SoC [5.10.y-cip,01/24] ASoC: dt-bindings: Document RZ/G2L bindings [5.10.y-cip,02/24] ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support [5.10.y-cip,03/24] ASoC: dt-bindings: renesas,rz-ssi: Update slave dma channel configuration parame… [5.10.y-cip,04/24] ASoC: sh: Add RZ/G2L SSIF-2 driver [5.10.y-cip,05/24] ASoC: sh: rz-ssi: Add SSI DMAC support [5.10.y-cip,06/24] ASoC: sh: rz-ssi: Fix dereference of noderef expression warning [5.10.y-cip,07/24] ASoC: sh: rz-ssi: Fix wrong operator used issue [5.10.y-cip,08/24] ASoC: sh: rz-ssi: Improve error handling in rz_ssi_dma_request function [5.10.y-cip,09/24] ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get() [5.10.y-cip,10/24] ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively [5.10.y-cip,11/24] ASoC: sh: rz-ssi: Make the data structures available before registering the hand… [5.10.y-cip,12/24] ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init() [5.10.y-cip,13/24] ASoC: sh: rz-ssi: Make return type of rz_ssi_stream_is_valid() to bool [5.10.y-cip,14/24] ASoC: sh: rz-ssi: Use a do-while loop in rz_ssi_pio_recv() [5.10.y-cip,15/24] ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function [5.10.y-cip,16/24] ASoC: sh: rz-ssi: Remove duplicate macros [5.10.y-cip,17/24] arm64: dts: renesas: r9a07g044: Add external audio clock nodes [5.10.y-cip,18/24] arm64: dts: renesas: r9a07g044: Add SSI support [5.10.y-cip,19/24] arm64: dts: renesas: r9a07g044: Add DMA support to SSI [5.10.y-cip,20/24] arm64: dts: renesas: rzg2l-smarc: Add WM8978 sound codec [5.10.y-cip,21/24] arm64: dts: renesas: rzg2l-smarc: Enable audio [5.10.y-cip,22/24] arm64: dts: renesas: rzg2l-smarc: Add Mic routing [5.10.y-cip,23/24] arm64: defconfig: Enable SOUND_SOC_RZ [5.10.y-cip,24/24] arm64: defconfig: Enable SND_SOC_WM8978

Message ID

20220420213424.27837-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)

Headers

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Pavel Machek <pavel@denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>
Subject: [PATCH 5.10.y-cip 00/24] Add sound support to Renesas RZ/G2L SoC
Date: Wed, 20 Apr 2022 22:34:00 +0100
Message-Id: <20220420213424.27837-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Series

Add sound support to Renesas RZ/G2L SoC | expand

Message

Lad Prabhakar April 20, 2022, 9:34 p.m. UTC

Hi All,

This patch series adds sound support to Renesas RZ/G2L SoC and enables
SSI and codec on Renesas RZ/G2L SMARC EVK.

All the patches have been cherry picked from v5.18-rc3.

Sound support patches were already sent earlier as part of bulk series
[0], but due to some review comments the patches were rejected, now that
the driver is fixed upstream, re-sending the series with all the fixes.

[0] https://patchwork.kernel.org/project/cip-dev/cover/
20211229101530.22783-1-prabhakar.mahadev-lad.rj@bp.renesas.com/

Cheers,
Prabhakar

Biju Das (16):
  ASoC: dt-bindings: Document RZ/G2L bindings
  ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support
  ASoC: dt-bindings: renesas,rz-ssi: Update slave dma channel
    configuration parameter
  ASoC: sh: Add RZ/G2L SSIF-2 driver
  ASoC: sh: rz-ssi: Add SSI DMAC support
  ASoC: sh: rz-ssi: Fix dereference of noderef expression warning
  ASoC: sh: rz-ssi: Fix wrong operator used issue
  ASoC: sh: rz-ssi: Improve error handling in rz_ssi_dma_request
    function
  arm64: dts: renesas: r9a07g044: Add external audio clock nodes
  arm64: dts: renesas: r9a07g044: Add SSI support
  arm64: dts: renesas: r9a07g044: Add DMA support to SSI
  arm64: dts: renesas: rzg2l-smarc: Add WM8978 sound codec
  arm64: dts: renesas: rzg2l-smarc: Enable audio
  arm64: dts: renesas: rzg2l-smarc: Add Mic routing
  arm64: defconfig: Enable SOUND_SOC_RZ
  arm64: defconfig: Enable SND_SOC_WM8978

Heiner Kallweit (1):
  ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get()

Lad Prabhakar (7):
  ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively
  ASoC: sh: rz-ssi: Make the data structures available before
    registering the handlers
  ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init()
  ASoC: sh: rz-ssi: Make return type of rz_ssi_stream_is_valid() to bool
  ASoC: sh: rz-ssi: Use a do-while loop in rz_ssi_pio_recv()
  ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function
  ASoC: sh: rz-ssi: Remove duplicate macros

 .../bindings/sound/renesas,rz-ssi.yaml        |  118 ++
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi    |   98 ++
 arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi  |   79 ++
 arch/arm64/configs/defconfig                  |    2 +
 sound/soc/sh/Kconfig                          |    6 +
 sound/soc/sh/Makefile                         |    4 +
 sound/soc/sh/rz-ssi.c                         | 1078 +++++++++++++++++
 7 files changed, 1385 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
 create mode 100644 sound/soc/sh/rz-ssi.c

Comments

Nobuhiro Iwamatsu April 21, 2022, 3:25 a.m. UTC | #1

Hi all,

> -----Original Message-----
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Sent: Thursday, April 21, 2022 6:34 AM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯Ａ
> ＣＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>
> Subject: [PATCH 5.10.y-cip 00/24] Add sound support to Renesas RZ/G2L SoC
> 
> Hi All,
> 
> This patch series adds sound support to Renesas RZ/G2L SoC and enables SSI
> and codec on Renesas RZ/G2L SMARC EVK.
> 
> All the patches have been cherry picked from v5.18-rc3.
> 
> Sound support patches were already sent earlier as part of bulk series [0], but
> due to some review comments the patches were rejected, now that the driver is
> fixed upstream, re-sending the series with all the fixes.
> 
> [0] https://patchwork.kernel.org/project/cip-dev/cover/
> 20211229101530.22783-1-prabhakar.mahadev-lad.rj@bp.renesas.com/

Looks good to me. 
I am testing on https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/521117833.
I can merge it if there are no other comments and test is successful.

> 
> Cheers,
> Prabhakar
> 

Best regards,
  Nobuhiro

> Biju Das (16):
>   ASoC: dt-bindings: Document RZ/G2L bindings
>   ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support
>   ASoC: dt-bindings: renesas,rz-ssi: Update slave dma channel
>     configuration parameter
>   ASoC: sh: Add RZ/G2L SSIF-2 driver
>   ASoC: sh: rz-ssi: Add SSI DMAC support
>   ASoC: sh: rz-ssi: Fix dereference of noderef expression warning
>   ASoC: sh: rz-ssi: Fix wrong operator used issue
>   ASoC: sh: rz-ssi: Improve error handling in rz_ssi_dma_request
>     function
>   arm64: dts: renesas: r9a07g044: Add external audio clock nodes
>   arm64: dts: renesas: r9a07g044: Add SSI support
>   arm64: dts: renesas: r9a07g044: Add DMA support to SSI
>   arm64: dts: renesas: rzg2l-smarc: Add WM8978 sound codec
>   arm64: dts: renesas: rzg2l-smarc: Enable audio
>   arm64: dts: renesas: rzg2l-smarc: Add Mic routing
>   arm64: defconfig: Enable SOUND_SOC_RZ
>   arm64: defconfig: Enable SND_SOC_WM8978
> 
> Heiner Kallweit (1):
>   ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get()
> 
> Lad Prabhakar (7):
>   ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively
>   ASoC: sh: rz-ssi: Make the data structures available before
>     registering the handlers
>   ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init()
>   ASoC: sh: rz-ssi: Make return type of rz_ssi_stream_is_valid() to bool
>   ASoC: sh: rz-ssi: Use a do-while loop in rz_ssi_pio_recv()
>   ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function
>   ASoC: sh: rz-ssi: Remove duplicate macros
> 
>  .../bindings/sound/renesas,rz-ssi.yaml        |  118 ++
>  arch/arm64/boot/dts/renesas/r9a07g044.dtsi    |   98 ++
>  arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi  |   79 ++
>  arch/arm64/configs/defconfig                  |    2 +
>  sound/soc/sh/Kconfig                          |    6 +
>  sound/soc/sh/Makefile                         |    4 +
>  sound/soc/sh/rz-ssi.c                         | 1078
> +++++++++++++++++
>  7 files changed, 1385 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
>  create mode 100644 sound/soc/sh/rz-ssi.c
> 
> --
> 2.17.1

Pavel Machek April 21, 2022, 11:17 a.m. UTC | #2

Hi!

> > This patch series adds sound support to Renesas RZ/G2L SoC and enables SSI
> > and codec on Renesas RZ/G2L SMARC EVK.
> > 
> > All the patches have been cherry picked from v5.18-rc3.
> > 
> > Sound support patches were already sent earlier as part of bulk series [0], but
> > due to some review comments the patches were rejected, now that the driver is
> > fixed upstream, re-sending the series with all the fixes.
> > 
> > [0] https://patchwork.kernel.org/project/cip-dev/cover/
> > 20211229101530.22783-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
> 
> Looks good to me. 
> I am testing on https://gitlab.com/cip-project/cip-kernel/linux-cip/-/pipelines/521117833.
> I can merge it if there are no other comments and test is successful.
> 

Aside from minor comments I sent, series looks good to me. I'm okay
with series being merged.

Thanks and best regards,
								Pavel

Lad Prabhakar April 25, 2022, 5:52 a.m. UTC | #3

Hi Nobuhiro-san,

> -----Original Message-----
> From: nobuhiro1.iwamatsu@toshiba.co.jp <nobuhiro1.iwamatsu@toshiba.co.jp>
> Sent: 21 April 2022 04:26
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; cip-
> dev@lists.cip-project.org; pavel@denx.de
> Cc: Biju Das <biju.das.jz@bp.renesas.com>
> Subject: RE: [PATCH 5.10.y-cip 00/24] Add sound support to Renesas RZ/G2L
> SoC
> 
> Hi all,
> 
> > -----Original Message-----
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Sent: Thursday, April 21, 2022 6:34 AM
> > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯
> Ａ
> > ＣＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>
> > Cc: Biju Das <biju.das.jz@bp.renesas.com>
> > Subject: [PATCH 5.10.y-cip 00/24] Add sound support to Renesas RZ/G2L
> > SoC
> >
> > Hi All,
> >
> > This patch series adds sound support to Renesas RZ/G2L SoC and enables
> > SSI and codec on Renesas RZ/G2L SMARC EVK.
> >
> > All the patches have been cherry picked from v5.18-rc3.
> >
> > Sound support patches were already sent earlier as part of bulk series
> > [0], but due to some review comments the patches were rejected, now
> > that the driver is fixed upstream, re-sending the series with all the
> fixes.
> >
> > [0]
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > hwork.kernel.org%2Fproject%2Fcip-dev%2Fcover%2F&amp;data=05%7C01%7Cpra
> > bhakar.mahadev-lad.rj%40bp.renesas.com%7Cb4ee1a6285394d44892508da2346a
> > 0d8%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C637861083493803991%7C
> > Unknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h
> > aWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=tb4S87F0MCvezWQFTwYhtfUNP
> > ErdCwkz9JsE%2FWJK9qQ%3D&amp;reserved=0
> > 20211229101530.22783-1-prabhakar.mahadev-lad.rj@bp.renesas.com/
> 
> Looks good to me.
> I am testing on
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.c
> om%2Fcip-project%2Fcip-kernel%2Flinux-cip%2F-
> %2Fpipelines%2F521117833&amp;data=05%7C01%7Cprabhakar.mahadev-
> lad.rj%40bp.renesas.com%7Cb4ee1a6285394d44892508da2346a0d8%7C53d82571da194
> 7e49cb4625a166a4a2a%7C0%7C0%7C637861083493803991%7CUnknown%7CTWFpbGZsb3d8e
> yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7
> C%7C%7C&amp;sdata=hAsfuV2fT66SH6cFpfI8cuUQMO8QVozG7EVlYAhMRu8%3D&amp;reser
> ved=0.
> I can merge it if there are no other comments and test is successful.
> 
Looks like there is one test failure, pretty sure its unrelated to the changes. Can you please retrigger the failed test so that this patch set gets merged in.

Cheers,
Prabhakar

> >
> > Cheers,
> > Prabhakar
> >
> 
> Best regards,
>   Nobuhiro
> 
> > Biju Das (16):
> >   ASoC: dt-bindings: Document RZ/G2L bindings
> >   ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support
> >   ASoC: dt-bindings: renesas,rz-ssi: Update slave dma channel
> >     configuration parameter
> >   ASoC: sh: Add RZ/G2L SSIF-2 driver
> >   ASoC: sh: rz-ssi: Add SSI DMAC support
> >   ASoC: sh: rz-ssi: Fix dereference of noderef expression warning
> >   ASoC: sh: rz-ssi: Fix wrong operator used issue
> >   ASoC: sh: rz-ssi: Improve error handling in rz_ssi_dma_request
> >     function
> >   arm64: dts: renesas: r9a07g044: Add external audio clock nodes
> >   arm64: dts: renesas: r9a07g044: Add SSI support
> >   arm64: dts: renesas: r9a07g044: Add DMA support to SSI
> >   arm64: dts: renesas: rzg2l-smarc: Add WM8978 sound codec
> >   arm64: dts: renesas: rzg2l-smarc: Enable audio
> >   arm64: dts: renesas: rzg2l-smarc: Add Mic routing
> >   arm64: defconfig: Enable SOUND_SOC_RZ
> >   arm64: defconfig: Enable SND_SOC_WM8978
> >
> > Heiner Kallweit (1):
> >   ASoC: sh: rz-ssi: Check return value of pm_runtime_resume_and_get()
> >
> > Lad Prabhakar (7):
> >   ASoC: sh: rz-ssi: Drop calling rz_ssi_pio_recv() recursively
> >   ASoC: sh: rz-ssi: Make the data structures available before
> >     registering the handlers
> >   ASoC: sh: rz-ssi: Drop ssi parameter from rz_ssi_stream_init()
> >   ASoC: sh: rz-ssi: Make return type of rz_ssi_stream_is_valid() to bool
> >   ASoC: sh: rz-ssi: Use a do-while loop in rz_ssi_pio_recv()
> >   ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function
> >   ASoC: sh: rz-ssi: Remove duplicate macros
> >
> >  .../bindings/sound/renesas,rz-ssi.yaml        |  118 ++
> >  arch/arm64/boot/dts/renesas/r9a07g044.dtsi    |   98 ++
> >  arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi  |   79 ++
> >  arch/arm64/configs/defconfig                  |    2 +
> >  sound/soc/sh/Kconfig                          |    6 +
> >  sound/soc/sh/Makefile                         |    4 +
> >  sound/soc/sh/rz-ssi.c                         | 1078
> > +++++++++++++++++
> >  7 files changed, 1385 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> >  create mode 100644 sound/soc/sh/rz-ssi.c
> >
> > --
> > 2.17.1

Nobuhiro Iwamatsu April 25, 2022, 7:25 a.m. UTC | #4

Hi Prabhakar,

> > Looks good to me.
> > I am testing on
> > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl
> > ab.c
> > om%2Fcip-project%2Fcip-kernel%2Flinux-cip%2F-
> > %2Fpipelines%2F521117833&amp;data=05%7C01%7Cprabhakar.mahadev-
> >
> lad.rj%40bp.renesas.com%7Cb4ee1a6285394d44892508da2346a0d8%7C53d8
> 2571d
> > a194
> >
> 7e49cb4625a166a4a2a%7C0%7C0%7C637861083493803991%7CUnknown%7C
> TWFpbGZsb
> > 3d8e
> >
> yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%7C30
> > 00%7
> >
> C%7C%7C&amp;sdata=hAsfuV2fT66SH6cFpfI8cuUQMO8QVozG7EVlYAhMR
> u8%3D&amp;r
> > eser
> > ved=0.
> > I can merge it if there are no other comments and test is successful.
> >
> Looks like there is one test failure, pretty sure its unrelated to the changes. Can
> you please retrigger the failed test so that this patch set gets merged in.

Yeah, I already retrigger it. And I planning to release a kernel including these patches.
Sorry for the late schedule.

Best regards,
  Nobuhiro