| Message ID | 20220422191239.6271-2-quic_amelende@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v6] dt-bindings: power: reset: qcom-pon: update "reg" property details | expand |
On Fri, Apr 22, 2022 at 12:12:38PM -0700, Anjelique Melendez wrote: > From: David Collins <collinsd@quicinc.com> > > Update the description of "reg" property to add the PON_PBS base > address along with PON_HLOS base address. Also add "reg-names" > property description. > > Signed-off-by: David Collins <quic_collinsd@quicinc.com> > Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> > --- > .../bindings/power/reset/qcom,pon.yaml | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > index 353f155d..65ec8197 100644 > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > @@ -26,7 +26,24 @@ properties: > - qcom,pm8998-pon > > reg: > - maxItems: 1 > + description: | > + Specifies the SPMI base address for the PON (power-on) peripheral. For > + PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS > + (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS > + peripherals. In that case, the PON_PBS address needs to be specified to > + facilitate software debouncing on some PMICs. > + minItems: 1 > + maxItems: 2 > + > + reg-names: > + description: | > + For PON GEN1 and GEN2, it should be "pon". For PON GEN3 it should include > + "pon_hlos" and optionally "pon_pbs". > + minItems: 1 > + items: > + - const: pon_hlos > + - const: pon_pbs > + - const: pon Did you test that 'reg-names = "pon";' works? It doesn't. The schema says 'pon' is the 3rd entry in reg-names. As 'reg-names' is new I thin this should be: items: - const: hlos - const: pbs And if there's 1 entry, then 'reg-names' should not be there. Rob
On 4/25/2022 2:45 PM, Rob Herring wrote: > On Fri, Apr 22, 2022 at 12:12:38PM -0700, Anjelique Melendez wrote: >> From: David Collins <collinsd@quicinc.com> >> >> Update the description of "reg" property to add the PON_PBS base >> address along with PON_HLOS base address. Also add "reg-names" >> property description. >> >> Signed-off-by: David Collins <quic_collinsd@quicinc.com> >> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> >> --- >> .../bindings/power/reset/qcom,pon.yaml | 19 ++++++++++++++++++- >> 1 file changed, 18 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >> index 353f155d..65ec8197 100644 >> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml >> @@ -26,7 +26,24 @@ properties: >> - qcom,pm8998-pon >> >> reg: >> - maxItems: 1 >> + description: | >> + Specifies the SPMI base address for the PON (power-on) peripheral. For >> + PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS >> + (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS >> + peripherals. In that case, the PON_PBS address needs to be specified to >> + facilitate software debouncing on some PMICs. >> + minItems: 1 >> + maxItems: 2 >> + >> + reg-names: >> + description: | >> + For PON GEN1 and GEN2, it should be "pon". For PON GEN3 it should include >> + "pon_hlos" and optionally "pon_pbs". >> + minItems: 1 >> + items: >> + - const: pon_hlos >> + - const: pon_pbs >> + - const: pon > > Did you test that 'reg-names = "pon";' works? It doesn't. The schema > says 'pon' is the 3rd entry in reg-names. > > As 'reg-names' is new I thin this should be: > > items: > - const: hlos > - const: pbs > > And if there's 1 entry, then 'reg-names' should not be there. > > Rob currently reg-names is not consumed by the pm8941 driver but rather for users to understand what each reg address is associated with. With this being the case would the following be acceptable? minItems: 1 maxItems: 2 items: anyOf: - const: pon_hlos - const: pon_pbs - const: pon If not we would be ok with getting rid of the reg-name property.
diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml index 353f155d..65ec8197 100644 --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml @@ -26,7 +26,24 @@ properties: - qcom,pm8998-pon reg: - maxItems: 1 + description: | + Specifies the SPMI base address for the PON (power-on) peripheral. For + PMICs that have the PON peripheral (GEN3) split into PON_HLOS and PON_PBS + (e.g. PMK8350), this can hold addresses of both PON_HLOS and PON_PBS + peripherals. In that case, the PON_PBS address needs to be specified to + facilitate software debouncing on some PMICs. + minItems: 1 + maxItems: 2 + + reg-names: + description: | + For PON GEN1 and GEN2, it should be "pon". For PON GEN3 it should include + "pon_hlos" and optionally "pon_pbs". + minItems: 1 + items: + - const: pon_hlos + - const: pon_pbs + - const: pon pwrkey: type: object