| Message ID | 20220426111715.627609-1-wanjiabing@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | cpufreq: mediatek: Fix NULL pointer dereference in mediatek-cpufreq | expand |
On 26/04/2022 13:17, Wan Jiabing wrote: > Fix following coccicheck error: > drivers/cpufreq/mediatek-cpufreq.c:464:16-23: ERROR: info is NULL but dereferenced. > > Use pr_err instead of dev_err to avoid dereferring a NULL pointer. > > Fixes: f52b16ba9fe4 ("cpufreq: mediatek: Use device print to show logs") > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/cpufreq/mediatek-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c > index bcabb3726a5b..901042e9a240 100644 > --- a/drivers/cpufreq/mediatek-cpufreq.c > +++ b/drivers/cpufreq/mediatek-cpufreq.c > @@ -461,8 +461,8 @@ static int mtk_cpufreq_init(struct cpufreq_policy *policy) > > info = mtk_cpu_dvfs_info_lookup(policy->cpu); > if (!info) { > - dev_err(info->cpu_dev, > - "dvfs info for cpu%d is not initialized.\n", policy->cpu); > + pr_err("dvfs info for cpu%d is not initialized.\n", > + policy->cpu); > return -EINVAL; > } >
On 26-04-22, 19:17, Wan Jiabing wrote: > Fix following coccicheck error: > drivers/cpufreq/mediatek-cpufreq.c:464:16-23: ERROR: info is NULL but dereferenced. > > Use pr_err instead of dev_err to avoid dereferring a NULL pointer. > > Fixes: f52b16ba9fe4 ("cpufreq: mediatek: Use device print to show logs") > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> > --- > drivers/cpufreq/mediatek-cpufreq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c > index bcabb3726a5b..901042e9a240 100644 > --- a/drivers/cpufreq/mediatek-cpufreq.c > +++ b/drivers/cpufreq/mediatek-cpufreq.c > @@ -461,8 +461,8 @@ static int mtk_cpufreq_init(struct cpufreq_policy *policy) > > info = mtk_cpu_dvfs_info_lookup(policy->cpu); > if (!info) { > - dev_err(info->cpu_dev, > - "dvfs info for cpu%d is not initialized.\n", policy->cpu); > + pr_err("dvfs info for cpu%d is not initialized.\n", > + policy->cpu); > return -EINVAL; > } Applied. Thanks.
diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c index bcabb3726a5b..901042e9a240 100644 --- a/drivers/cpufreq/mediatek-cpufreq.c +++ b/drivers/cpufreq/mediatek-cpufreq.c @@ -461,8 +461,8 @@ static int mtk_cpufreq_init(struct cpufreq_policy *policy) info = mtk_cpu_dvfs_info_lookup(policy->cpu); if (!info) { - dev_err(info->cpu_dev, - "dvfs info for cpu%d is not initialized.\n", policy->cpu); + pr_err("dvfs info for cpu%d is not initialized.\n", + policy->cpu); return -EINVAL; }
Fix following coccicheck error: drivers/cpufreq/mediatek-cpufreq.c:464:16-23: ERROR: info is NULL but dereferenced. Use pr_err instead of dev_err to avoid dereferring a NULL pointer. Fixes: f52b16ba9fe4 ("cpufreq: mediatek: Use device print to show logs") Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> --- drivers/cpufreq/mediatek-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)