| Message ID | 20220316151327.564214-2-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce support for MediaTek MT8192 Google Chromebooks | expand |
Hi, On Wed, Mar 16, 2022 at 11:17 PM Nícolas F. R. A. Prado <nfraprado@collabora.com> wrote: > > Introduce the MT8192 Asurada Chromebook platform, including the Asurada > Spherion and Asurada Hayato boards. > > This is enough configuration to get serial output working on Spherion > and Hayato. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > arch/arm64/boot/dts/mediatek/Makefile | 2 ++ > .../dts/mediatek/mt8192-asurada-hayato-r1.dts | 11 ++++++++ > .../mediatek/mt8192-asurada-spherion-r0.dts | 13 ++++++++++ > .../boot/dts/mediatek/mt8192-asurada.dtsi | 26 +++++++++++++++++++ > 4 files changed, 52 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > index 8c1e18032f9f..034cba17276b 100644 > --- a/arch/arm64/boot/dts/mediatek/Makefile > +++ b/arch/arm64/boot/dts/mediatek/Makefile > @@ -37,5 +37,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku32.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-pumpkin.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-asurada-hayato-r1.dtb > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-asurada-spherion-r0.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts > new file mode 100644 > index 000000000000..e18e14b13d61 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts > @@ -0,0 +1,11 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2020 Google LLC > + */ > +/dts-v1/; > +#include "mt8192-asurada.dtsi" > + > +/ { > + model = "MediaTek Hayato rev1"; I think this should be "Google Hayato ...", and the one in spherion should read "Google Spherion" as well? These are project code names used in Google. Both devices use the common "Asurada" hardware design, also done by Google. > + compatible = "google,hayato-rev1", "google,hayato", "mediatek,mt8192"; You should add a patch adding this to the DT binding doc Documentation/devicetree/bindings/arm/mediatek.yaml Same for Spherion. Regards ChenYu > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts > new file mode 100644 > index 000000000000..b5372ce6bd95 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts > @@ -0,0 +1,13 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2021 Google LLC > + */ > +/dts-v1/; > +#include "mt8192-asurada.dtsi" > + > +/ { > + model = "MediaTek Spherion (rev0 - 3)"; > + compatible = "google,spherion-rev3", "google,spherion-rev2", > + "google,spherion-rev1", "google,spherion-rev0", > + "google,spherion", "mediatek,mt8192"; > +}; > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > new file mode 100644 > index 000000000000..277bd38943fe > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > @@ -0,0 +1,26 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright (C) 2020 MediaTek Inc. > + * Author: Seiya Wang <seiya.wang@mediatek.com> > + */ > +/dts-v1/; > +#include "mt8192.dtsi" > + > +/ { > + aliases { > + serial0 = &uart0; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0 0x40000000 0 0x80000000>; > + }; > +}; > + > +&uart0 { > + status = "okay"; > +}; > -- > 2.35.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Chen-Yu, thank you for the review. On Wed, Apr 27, 2022 at 04:43:50PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Wed, Mar 16, 2022 at 11:17 PM Nícolas F. R. A. Prado > <nfraprado@collabora.com> wrote: > > > > Introduce the MT8192 Asurada Chromebook platform, including the Asurada > > Spherion and Asurada Hayato boards. > > > > This is enough configuration to get serial output working on Spherion > > and Hayato. > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > > --- > > > > arch/arm64/boot/dts/mediatek/Makefile | 2 ++ > > .../dts/mediatek/mt8192-asurada-hayato-r1.dts | 11 ++++++++ > > .../mediatek/mt8192-asurada-spherion-r0.dts | 13 ++++++++++ > > .../boot/dts/mediatek/mt8192-asurada.dtsi | 26 +++++++++++++++++++ > > 4 files changed, 52 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > > > diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile > > index 8c1e18032f9f..034cba17276b 100644 > > --- a/arch/arm64/boot/dts/mediatek/Makefile > > +++ b/arch/arm64/boot/dts/mediatek/Makefile > > @@ -37,5 +37,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku32.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-pumpkin.dtb > > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-asurada-hayato-r1.dtb > > +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-asurada-spherion-r0.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb > > dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts > > new file mode 100644 > > index 000000000000..e18e14b13d61 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts > > @@ -0,0 +1,11 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +/* > > + * Copyright 2020 Google LLC > > + */ > > +/dts-v1/; > > +#include "mt8192-asurada.dtsi" > > + > > +/ { > > + model = "MediaTek Hayato rev1"; > > I think this should be "Google Hayato ...", and the one in spherion should > read "Google Spherion" as well? > > These are project code names used in Google. Both devices use the common > "Asurada" hardware design, also done by Google. These were the names downstream so I didn't want to change them. But I agree with you, and will take this as authorization do change them so for the next version. > > > + compatible = "google,hayato-rev1", "google,hayato", "mediatek,mt8192"; > > You should add a patch adding this to the DT binding doc > Documentation/devicetree/bindings/arm/mediatek.yaml > > Same for Spherion. Okay. Thanks, Nícolas
diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index 8c1e18032f9f..034cba17276b 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -37,5 +37,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku32.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-pumpkin.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-asurada-hayato-r1.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-asurada-spherion-r0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts new file mode 100644 index 000000000000..e18e14b13d61 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts @@ -0,0 +1,11 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2020 Google LLC + */ +/dts-v1/; +#include "mt8192-asurada.dtsi" + +/ { + model = "MediaTek Hayato rev1"; + compatible = "google,hayato-rev1", "google,hayato", "mediatek,mt8192"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts new file mode 100644 index 000000000000..b5372ce6bd95 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts @@ -0,0 +1,13 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright 2021 Google LLC + */ +/dts-v1/; +#include "mt8192-asurada.dtsi" + +/ { + model = "MediaTek Spherion (rev0 - 3)"; + compatible = "google,spherion-rev3", "google,spherion-rev2", + "google,spherion-rev1", "google,spherion-rev0", + "google,spherion", "mediatek,mt8192"; +}; diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi new file mode 100644 index 000000000000..277bd38943fe --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi @@ -0,0 +1,26 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright (C) 2020 MediaTek Inc. + * Author: Seiya Wang <seiya.wang@mediatek.com> + */ +/dts-v1/; +#include "mt8192.dtsi" + +/ { + aliases { + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + memory@40000000 { + device_type = "memory"; + reg = <0 0x40000000 0 0x80000000>; + }; +}; + +&uart0 { + status = "okay"; +};