| Message ID | 20220421090016.79517-3-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | RZN1 RTC support | expand |
The subject should start with clk:, not soc: Quoting Miquel Raynal (2022-04-21 02:00:11) > It needs to be un-gated, but also a reset must be released and an idle > flag should also be disabled. > > The driver already supports all these operations, so update the > description of the RTC hclock to fit these requirements. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/clk/renesas/r9a06g032-clocks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Otherwise Acked-by: Stephen Boyd <sboyd@kernel.org>
On Thu, Apr 21, 2022 at 11:00 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote: > It needs to be un-gated, but also a reset must be released and an idle > flag should also be disabled. > > The driver already supports all these operations, so update the > description of the RTC hclock to fit these requirements. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, will queue in renesas-devel for v5.19, with the prefix fixed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, geert@linux-m68k.org wrote on Wed, 27 Apr 2022 17:32:58 +0200: > On Thu, Apr 21, 2022 at 11:00 AM Miquel Raynal > <miquel.raynal@bootlin.com> wrote: > > It needs to be un-gated, but also a reset must be released and an idle > > flag should also be disabled. > > > > The driver already supports all these operations, so update the > > description of the RTC hclock to fit these requirements. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > Thanks, will queue in renesas-devel for v5.19, with the prefix fixed. I no longer remember why I chose this one in the first place. Should be something like "clk: renesas: r9a06g032:". Thanks, Miquèl
On Wed, Apr 27, 2022 at 5:32 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Thu, Apr 21, 2022 at 11:00 AM Miquel Raynal > <miquel.raynal@bootlin.com> wrote: > > It needs to be un-gated, but also a reset must be released and an idle > > flag should also be disabled. > > > > The driver already supports all these operations, so update the > > description of the RTC hclock to fit these requirements. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > Thanks, will queue in renesas-devel for v5.19, with the prefix fixed. Doh, renesas-clk-for-v5.19. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c index 1df56d7ab3e1..5bd125552b56 100644 --- a/drivers/clk/renesas/r9a06g032-clocks.c +++ b/drivers/clk/renesas/r9a06g032-clocks.c @@ -260,7 +260,7 @@ static const struct r9a06g032_clkdesc r9a06g032_clocks[] = { D_MODULE(HCLK_QSPI0, "hclk_qspi0", CLK_REF_SYNC_D4, 0x2a0, 0x2a1, 0x2a2, 0x2a3, 0x300, 0x301, 0x302), D_MODULE(HCLK_QSPI1, "hclk_qspi1", CLK_REF_SYNC_D4, 0x480, 0x481, 0x482, 0x483, 0x4c0, 0x4c1, 0x4c2), D_MODULE(HCLK_ROM, "hclk_rom", CLK_REF_SYNC_D4, 0xaa0, 0xaa1, 0xaa2, 0, 0xb80, 0, 0), - D_MODULE(HCLK_RTC, "hclk_rtc", CLK_REF_SYNC_D8, 0xa00, 0, 0, 0, 0, 0, 0), + D_MODULE(HCLK_RTC, "hclk_rtc", CLK_REF_SYNC_D8, 0xa00, 0xa03, 0, 0xa02, 0, 0, 0), D_MODULE(HCLK_SDIO0, "hclk_sdio0", CLK_REF_SYNC_D4, 0x60, 0x61, 0x62, 0x63, 0x80, 0x81, 0x82), D_MODULE(HCLK_SDIO1, "hclk_sdio1", CLK_REF_SYNC_D4, 0x640, 0x641, 0x642, 0x643, 0x660, 0x661, 0x662), D_MODULE(HCLK_SEMAP, "hclk_semap", CLK_REF_SYNC_D4, 0x7a3, 0x7a4, 0x7a5, 0, 0xb21, 0, 0),
It needs to be un-gated, but also a reset must be released and an idle flag should also be disabled. The driver already supports all these operations, so update the description of the RTC hclock to fit these requirements. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/clk/renesas/r9a06g032-clocks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)