| Message ID | 20220426132139.26761-6-linux@fw-web.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | RK3568 PCIe V3 support | expand |
On 26/04/2022 15:21, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add bifurcation property for splitting PCIe lanes. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > index bc0a9d1db750..a992970e8b85 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > @@ -74,6 +74,8 @@ properties: > reset-names: > const: pipe > > + bifurcation: true > + Does not look like standard property. Is it already defined somewhere? All non-standard properties need vendor, type and description. Best regards, Krzysztof
Hi > Gesendet: Donnerstag, 28. April 2022 um 08:37 Uhr > Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> > On 26/04/2022 15:21, Frank Wunderlich wrote: > > From: Frank Wunderlich <frank-w@public-files.de> > > > > Add bifurcation property for splitting PCIe lanes. > > > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > > --- > > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > > index bc0a9d1db750..a992970e8b85 100644 > > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > > @@ -74,6 +74,8 @@ properties: > > reset-names: > > const: pipe > > > > + bifurcation: true > > + > > Does not look like standard property. Is it already defined somewhere? > All non-standard properties need vendor, type and description. have removed vendor-prefix from v1>v2 based on suggestion this can be useful for other vendors too. but last 3 patches of this series replacing bifurcation property (which is only bool) by the more useful lane-map (left alone for discussion, will be squashed if the right way is found). i guess same here, description+type needed, but how to describe an array of int in yaml? do you know any examples? regards Frank
On 28/04/2022 09:25, Frank Wunderlich wrote: > > i guess same here, description+type needed, but how to describe an array of int in yaml? do you know any examples? https://elixir.bootlin.com/linux/v5.17-rc4/source/Documentation/devicetree/bindings/arm/l2c2x0.yaml#L74 https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml#L101 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml index bc0a9d1db750..a992970e8b85 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml @@ -74,6 +74,8 @@ properties: reset-names: const: pipe + bifurcation: true + vpcie3v3-supply: true required: