| Message ID | 20220427180853.35970-4-kdasu.kdev@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sdhci-brcmstb: host controller clock enhancements | expand |
On 27/04/2022 20:08, Kamal Dasu wrote: Thank you for your patch. There is something to discuss/improve. > > clocks: > - maxItems: 1 > - description: > - handle to core clock for the sdhci controller. > + minItems: 1 > + items: > + - description: handle to core clock for the sdhci controller > + - description: improved 150Mhz clock for sdhci controller (Optional clock) > > clock-names: > + minItems: 1 > items: > - const: sw_sdio > + - const: sdio_freq # Optional clock > > sdhci,auto-cmd12: > type: boolean > description: Specifies that controller should use auto CMD12 > > +allOf: > + - $ref: mmc-controller.yaml# > + - if: > + properties: > + clock-names: > + contains: > + const: sdio_freq > + > + - then: This won't work. Please test your bindings. Best regards, Krzysztof
On 27/04/2022 20:08, Kamal Dasu wrote: > The 72116B0 has improved SDIO controllers that allow the max clock > rate to be increased from a max of 100MHz to a max of 150MHz. > Optional "sdio_freq" clock is used to drive the bus clock if present > optional property "max-frequency" specifies a base clock frequency > in Hz that overrides the base clock frequency in the CAPS registers. > > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> > --- > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 24 +++++++++++++++---- > 1 file changed, 19 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > index dccd5ad96981..bf716c0cf096 100644 > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > @@ -10,8 +10,6 @@ maintainers: > - Al Cooper <alcooperx@gmail.com> > - Florian Fainelli <f.fainelli@gmail.com> > > -allOf: > - - $ref: mmc-controller.yaml# You also leave here too many blank lines. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml index dccd5ad96981..bf716c0cf096 100644 --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml @@ -10,8 +10,6 @@ maintainers: - Al Cooper <alcooperx@gmail.com> - Florian Fainelli <f.fainelli@gmail.com> -allOf: - - $ref: mmc-controller.yaml# properties: compatible: @@ -42,23 +40,39 @@ properties: maxItems: 1 clocks: - maxItems: 1 - description: - handle to core clock for the sdhci controller. + minItems: 1 + items: + - description: handle to core clock for the sdhci controller + - description: improved 150Mhz clock for sdhci controller (Optional clock) clock-names: + minItems: 1 items: - const: sw_sdio + - const: sdio_freq # Optional clock sdhci,auto-cmd12: type: boolean description: Specifies that controller should use auto CMD12 +allOf: + - $ref: mmc-controller.yaml# + - if: + properties: + clock-names: + contains: + const: sdio_freq + + - then: + required: + - max-frequency + required: - compatible - reg - interrupts - clocks + - clock-names unevaluatedProperties: false
The 72116B0 has improved SDIO controllers that allow the max clock rate to be increased from a max of 100MHz to a max of 150MHz. Optional "sdio_freq" clock is used to drive the bus clock if present optional property "max-frequency" specifies a base clock frequency in Hz that overrides the base clock frequency in the CAPS registers. Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com> --- .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 24 +++++++++++++++---- 1 file changed, 19 insertions(+), 5 deletions(-)