| Message ID | 20220429114330.59026-5-robimarko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/6] clk: qcom: clk-alpha-pll: add support for APSS PLL | expand |
On Fri, Apr 29, 2022 at 6:43 AM Robert Marko <robimarko@gmail.com> wrote: > > IPQ6018 and IPQ8074 require #clock-cells to be set to 1 as their APSS > clock driver provides multiple clock outputs. > > So allow setting 1 as #clock-cells and check that its set to 1 for IPQ6018 > and IPQ8074, check others for 0 as its currently. > Please include qcom specific marker in the subject line. thanks.
On Fri, 29 Apr 2022 at 17:39, Jassi Brar <jassisinghbrar@gmail.com> wrote: > > On Fri, Apr 29, 2022 at 6:43 AM Robert Marko <robimarko@gmail.com> wrote: > > > > IPQ6018 and IPQ8074 require #clock-cells to be set to 1 as their APSS > > clock driver provides multiple clock outputs. > > > > So allow setting 1 as #clock-cells and check that its set to 1 for IPQ6018 > > and IPQ8074, check others for 0 as its currently. > > > Please include qcom specific marker in the subject line. Yeah, I see that I forgot to include the actual binding name. Will fixup in v2. Regards, Robert > > thanks.
On 29/04/2022 13:43, Robert Marko wrote: > IPQ6018 and IPQ8074 require #clock-cells to be set to 1 as their APSS > clock driver provides multiple clock outputs. > > So allow setting 1 as #clock-cells and check that its set to 1 for IPQ6018 > and IPQ8074, check others for 0 as its currently. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > .../mailbox/qcom,apcs-kpss-global.yaml | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) With the changes asked by Jassi: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 3b5ba7ecc19d..1f803925867e 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -50,7 +50,7 @@ properties: const: 1 '#clock-cells': - const: 0 + enum: [0, 1] clock-names: minItems: 2 @@ -96,6 +96,22 @@ allOf: properties: clocks: maxItems: 3 + - if: + properties: + compatible: + enum: + - qcom,ipq6018-apcs-apps-global + - qcom,ipq8074-apcs-apps-global + then: + properties: + '#clock-cells': + const: 1 + + else: + properties: + '#clock-cells': + const: 0 + examples: # Example apcs with msm8996
IPQ6018 and IPQ8074 require #clock-cells to be set to 1 as their APSS clock driver provides multiple clock outputs. So allow setting 1 as #clock-cells and check that its set to 1 for IPQ6018 and IPQ8074, check others for 0 as its currently. Signed-off-by: Robert Marko <robimarko@gmail.com> --- .../mailbox/qcom,apcs-kpss-global.yaml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)