| Message ID | 20220429114330.59026-2-robimarko@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/6] clk: qcom: clk-alpha-pll: add support for APSS PLL | expand |
On 29/04/2022 13:43, Robert Marko wrote: > Add DT-binding for the IPQ8074 APSS clock controller. > > Signed-off-by: Robert Marko <robimarko@gmail.com> These are dt-bindings, so prefix the title matching dt-bindings subsystem and remove "DT bindings" words form the title. Instead "Add clock ID headers for..." > --- > include/dt-bindings/clock/qcom,apss-ipq8074.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 include/dt-bindings/clock/qcom,apss-ipq8074.h > > diff --git a/include/dt-bindings/clock/qcom,apss-ipq8074.h b/include/dt-bindings/clock/qcom,apss-ipq8074.h > new file mode 100644 > index 000000000000..df07766b0146 > --- /dev/null > +++ b/include/dt-bindings/clock/qcom,apss-ipq8074.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ This should be licensed the same as bindings, so GPL|BSD, unless it's a derivative of some other work? Best regards, Krzysztof
On Fri, 29 Apr 2022 at 22:46, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 29/04/2022 13:43, Robert Marko wrote: > > Add DT-binding for the IPQ8074 APSS clock controller. > > > > Signed-off-by: Robert Marko <robimarko@gmail.com> > > These are dt-bindings, so prefix the title matching dt-bindings > subsystem and remove "DT bindings" words form the title. Instead "Add > clock ID headers for..." Ok, sorry for the mess-up, will fix up v2. > > > --- > > include/dt-bindings/clock/qcom,apss-ipq8074.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > create mode 100644 include/dt-bindings/clock/qcom,apss-ipq8074.h > > > > diff --git a/include/dt-bindings/clock/qcom,apss-ipq8074.h b/include/dt-bindings/clock/qcom,apss-ipq8074.h > > new file mode 100644 > > index 000000000000..df07766b0146 > > --- /dev/null > > +++ b/include/dt-bindings/clock/qcom,apss-ipq8074.h > > @@ -0,0 +1,14 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > This should be licensed the same as bindings, so GPL|BSD, unless it's a > derivative of some other work? It's derivated from IPQ6018 PLL bindings which are marked GPL-2.0 so I decided to keep that. Regards, Robert > > Best regards, > Krzysztof
On 29/04/2022 23:56, Robert Marko wrote: >>> +/* SPDX-License-Identifier: GPL-2.0 */ >> >> This should be licensed the same as bindings, so GPL|BSD, unless it's a >> derivative of some other work? > > It's derivated from IPQ6018 PLL bindings which are marked GPL-2.0 so I > decided to keep that. OK Best regards, Krzysztof
diff --git a/include/dt-bindings/clock/qcom,apss-ipq8074.h b/include/dt-bindings/clock/qcom,apss-ipq8074.h new file mode 100644 index 000000000000..df07766b0146 --- /dev/null +++ b/include/dt-bindings/clock/qcom,apss-ipq8074.h @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2021, The Linux Foundation. All rights reserved. + */ + +#ifndef _DT_BINDINGS_CLOCK_QCA_APSS_IPQ8074_H +#define _DT_BINDINGS_CLOCK_QCA_APSS_IPQ8074_H + +#define APSS_PLL_EARLY 0 +#define APSS_PLL 1 +#define APCS_ALIAS0_CLK_SRC 2 +#define APCS_ALIAS0_CORE_CLK 3 + +#endif
Add DT-binding for the IPQ8074 APSS clock controller. Signed-off-by: Robert Marko <robimarko@gmail.com> --- include/dt-bindings/clock/qcom,apss-ipq8074.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 include/dt-bindings/clock/qcom,apss-ipq8074.h