| Message ID | 20220429055226.3852334-1-chi.minghao@zte.com.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: sja1105: simplify the return expression of sja1105_cls_flower_stats() | expand |
On Fri, 29 Apr 2022 05:52:26 +0000 cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Simplify the return expression. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > --- > drivers/net/dsa/sja1105/sja1105_flower.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/net/dsa/sja1105/sja1105_flower.c b/drivers/net/dsa/sja1105/sja1105_flower.c > index fad5afe3819c..16c93159e475 100644 > --- a/drivers/net/dsa/sja1105/sja1105_flower.c > +++ b/drivers/net/dsa/sja1105/sja1105_flower.c > @@ -501,7 +501,6 @@ int sja1105_cls_flower_stats(struct dsa_switch *ds, int port, > { > struct sja1105_private *priv = ds->priv; > struct sja1105_rule *rule = sja1105_rule_find(priv, cls->cookie); > - int rc; > > if (!rule) > return 0; > @@ -509,12 +508,8 @@ int sja1105_cls_flower_stats(struct dsa_switch *ds, int port, > if (rule->type != SJA1105_RULE_VL) > return 0; > > - rc = sja1105_vl_stats(priv, port, rule, &cls->stats, > + return sja1105_vl_stats(priv, port, rule, &cls->stats, > cls->common.extack); align continuation line > - if (rc) > - return rc; > - > - return 0; > } > > void sja1105_flower_setup(struct dsa_switch *ds)
diff --git a/drivers/net/dsa/sja1105/sja1105_flower.c b/drivers/net/dsa/sja1105/sja1105_flower.c index fad5afe3819c..16c93159e475 100644 --- a/drivers/net/dsa/sja1105/sja1105_flower.c +++ b/drivers/net/dsa/sja1105/sja1105_flower.c @@ -501,7 +501,6 @@ int sja1105_cls_flower_stats(struct dsa_switch *ds, int port, { struct sja1105_private *priv = ds->priv; struct sja1105_rule *rule = sja1105_rule_find(priv, cls->cookie); - int rc; if (!rule) return 0; @@ -509,12 +508,8 @@ int sja1105_cls_flower_stats(struct dsa_switch *ds, int port, if (rule->type != SJA1105_RULE_VL) return 0; - rc = sja1105_vl_stats(priv, port, rule, &cls->stats, + return sja1105_vl_stats(priv, port, rule, &cls->stats, cls->common.extack); - if (rc) - return rc; - - return 0; } void sja1105_flower_setup(struct dsa_switch *ds)