| Message ID | 20220501081001.21563-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dt-bindings: iio: adc: Document Renesas RZ/G2UL ADC | expand |
On 01/05/2022 10:10, Biju Das wrote: > Document Renesas RZ/G2UL ADC bindings. RZ/G2UL ADC is identical to > RZ/G2L ADC but with fewer channels (2 vs 8) compared to RZ/G2L. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 18 ++++++++++++------ > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > index d66c24cae1e1..767fb734a1b5 100644 > --- a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > @@ -17,11 +17,15 @@ description: | > > properties: > compatible: > - items: > - - enum: > - - renesas,r9a07g044-adc # RZ/G2L > - - renesas,r9a07g054-adc # RZ/V2L > - - const: renesas,rzg2l-adc > + oneOf: > + - items: > + - const: renesas,renesas,r9a07g043-adc # RZ/G2UL It's not a list, so no items. > + > + - items: > + - enum: > + - renesas,r9a07g044-adc # RZ/G2L > + - renesas,r9a07g054-adc # RZ/V2L > + - const: renesas,rzg2l-adc > > reg: > maxItems: 1 > @@ -76,7 +80,9 @@ patternProperties: > properties: > reg: > description: | > - The channel number. It can have up to 8 channels numbered from 0 to 7. > + The channel number. It can have up to 8 channels numbered from 0 to 7 > + for RZ/{G2L,V2L} SoCs or 2 channels numbered from 0 to 1 for RZ/G2UL > + SoC. > items: > - minimum: 0 > maximum: 7 You need allOf:if:then restricting this per variant. Best regards, Krzysztof
Hi Krzysztof Kozlowski, Thanks for the feedback. > Subject: Re: [PATCH] dt-bindings: iio: adc: Document Renesas RZ/G2UL ADC > > On 01/05/2022 10:10, Biju Das wrote: > > Document Renesas RZ/G2UL ADC bindings. RZ/G2UL ADC is identical to > > RZ/G2L ADC but with fewer channels (2 vs 8) compared to RZ/G2L. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 18 ++++++++++++------ > > 1 file changed, 12 insertions(+), 6 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > > b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > > index d66c24cae1e1..767fb734a1b5 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > > @@ -17,11 +17,15 @@ description: | > > > > properties: > > compatible: > > - items: > > - - enum: > > - - renesas,r9a07g044-adc # RZ/G2L > > - - renesas,r9a07g054-adc # RZ/V2L > > - - const: renesas,rzg2l-adc > > + oneOf: > > + - items: > > + - const: renesas,renesas,r9a07g043-adc # RZ/G2UL > > It's not a list, so no items. Ok you mean. Get rid of Items and Just use - const: renesas,renesas,r9a07g043-adc # RZ/G2UL > > > + > > + - items: > > + - enum: > > + - renesas,r9a07g044-adc # RZ/G2L > > + - renesas,r9a07g054-adc # RZ/V2L > > + - const: renesas,rzg2l-adc > > > > reg: > > maxItems: 1 > > @@ -76,7 +80,9 @@ patternProperties: > > properties: > > reg: > > description: | > > - The channel number. It can have up to 8 channels numbered > from 0 to 7. > > + The channel number. It can have up to 8 channels numbered > from 0 to 7 > > + for RZ/{G2L,V2L} SoCs or 2 channels numbered from 0 to 1 for > RZ/G2UL > > + SoC. > > items: > > - minimum: 0 > > maximum: 7 > > You need allOf:if:then restricting this per variant. OK, Will do. Cheers, Biju > > > Best regards, > Krzysztof
On 01/05/2022 10:40, Biju Das wrote: >>> + oneOf: >>> + - items: >>> + - const: renesas,renesas,r9a07g043-adc # RZ/G2UL >> >> It's not a list, so no items. > > Ok you mean. Get rid of Items and Just use - const: renesas,renesas,r9a07g043-adc # RZ/G2UL Yes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml index d66c24cae1e1..767fb734a1b5 100644 --- a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml @@ -17,11 +17,15 @@ description: | properties: compatible: - items: - - enum: - - renesas,r9a07g044-adc # RZ/G2L - - renesas,r9a07g054-adc # RZ/V2L - - const: renesas,rzg2l-adc + oneOf: + - items: + - const: renesas,renesas,r9a07g043-adc # RZ/G2UL + + - items: + - enum: + - renesas,r9a07g044-adc # RZ/G2L + - renesas,r9a07g054-adc # RZ/V2L + - const: renesas,rzg2l-adc reg: maxItems: 1 @@ -76,7 +80,9 @@ patternProperties: properties: reg: description: | - The channel number. It can have up to 8 channels numbered from 0 to 7. + The channel number. It can have up to 8 channels numbered from 0 to 7 + for RZ/{G2L,V2L} SoCs or 2 channels numbered from 0 to 1 for RZ/G2UL + SoC. items: - minimum: 0 maximum: 7
Document Renesas RZ/G2UL ADC bindings. RZ/G2UL ADC is identical to RZ/G2L ADC but with fewer channels (2 vs 8) compared to RZ/G2L. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)