[0/7] qapi: Primarily whitespace tweaks

Message

Andrea Bolognani April 29, 2022, 3:47 p.m. UTC

The last patch could very reasonably be squashed into the previous
one, but since the changes could be considered more controversial I
thought it would be better if the two could be reviewed and judged
separately.

Andrea Bolognani (7):
  qapi: Drop stray trailing symbol
  qapi: Fix comment indentation
  qapi: Add missing separators between sections
  qapi: Drop unnecessary empty lines in comments
  qapi: Drop unnecessary empty lines outside of comments
  qapi: Drop unnecessary horizontal spacing in comments
  qapi: Drop more unnecessary horizontal spacing in comments

 qapi/audio.json          |  1 -
 qapi/block-core.json     | 97 ++++++++++++++++++----------------------
 qapi/block-export.json   |  2 +-
 qapi/block.json          | 13 +++---
 qapi/char.json           | 10 ++---
 qapi/common.json         |  2 -
 qapi/control.json        | 13 +++---
 qapi/crypto.json         | 62 ++++++++++++-------------
 qapi/dump.json           |  4 +-
 qapi/job.json            |  1 -
 qapi/machine-target.json |  1 -
 qapi/machine.json        | 12 +++--
 qapi/migration.json      | 19 ++++----
 qapi/misc-target.json    | 13 ++----
 qapi/misc.json           |  6 +--
 qapi/replay.json         |  1 -
 qapi/run-state.json      | 10 ++---
 qapi/sockets.json        |  6 +--
 qapi/ui.json             | 70 ++++++++++-------------------
 19 files changed, 136 insertions(+), 207 deletions(-)

Comments

Markus Armbruster May 2, 2022, 12:43 p.m. UTC | #1

PATCH 1-5 queued, because no-brainers :)

Andrea Bolognani May 2, 2022, 2:36 p.m. UTC | #2

On Mon, May 02, 2022 at 02:43:52PM +0200, Markus Armbruster wrote:
> PATCH 1-5 queued, because no-brainers :)

Thanks!

How do you want me to handle respinning 6/7 and 7/7? Send out the
entire series again with those two patches tweaked, wait for your
pull request to make it into the tree, something else... ?

What about the changes you suggested to the commit message of 3/7?

Markus Armbruster May 2, 2022, 5:28 p.m. UTC | #3

Andrea Bolognani <[e-mail]> writes:

> On Mon, May 02, 2022 at 02:43:52PM +0200, Markus Armbruster wrote:
>> PATCH 1-5 queued, because no-brainers :)
>
> Thanks!
>
> How do you want me to handle respinning 6/7 and 7/7? Send out the
> entire series again with those two patches tweaked, wait for your
> pull request to make it into the tree, something else... ?

If you like, I can post a pull request tomorrow morning.

Respinning the complete series is fine with me.

> What about the changes you suggested to the commit message of 3/7?

If you respin the complete series, you get to can amend it.  Else I do.