| Message ID | 20220426074334.9281-1-guozhengkui@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | qla2xxx: edif: remove unneeded variable | expand |
Guo, > Fix the following coccicheck warning: > > drivers/scsi/qla2xxx/qla_edif.c:660:11-15: Unneeded variable: "rval". > Return "0" on line 761. Applied to 5.19/scsi-staging, thanks!
On Tue, 26 Apr 2022 15:43:34 +0800, Guo Zhengkui wrote: > Fix the following coccicheck warning: > > drivers/scsi/qla2xxx/qla_edif.c:660:11-15: Unneeded variable: "rval". > Return "0" on line 761. > > Applied to 5.19/scsi-queue, thanks! [1/1] qla2xxx: edif: remove unneeded variable https://git.kernel.org/mkp/scsi/c/1497e95e22c3
diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c index 0628633c7c7e..cb8145a9ac09 100644 --- a/drivers/scsi/qla2xxx/qla_edif.c +++ b/drivers/scsi/qla2xxx/qla_edif.c @@ -657,7 +657,6 @@ qla_edif_app_chk_sa_update(scsi_qla_host_t *vha, fc_port_t *fcport, static int qla_edif_app_authok(scsi_qla_host_t *vha, struct bsg_job *bsg_job) { - int32_t rval = 0; struct auth_complete_cmd appplogiok; struct app_plogi_reply appplogireply = {0}; struct fc_bsg_reply *bsg_reply = bsg_job->reply; @@ -758,7 +757,7 @@ qla_edif_app_authok(scsi_qla_host_t *vha, struct bsg_job *bsg_job) &appplogireply, sizeof(struct app_plogi_reply)); - return rval; + return 0; } /**
Fix the following coccicheck warning: drivers/scsi/qla2xxx/qla_edif.c:660:11-15: Unneeded variable: "rval". Return "0" on line 761. Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> --- drivers/scsi/qla2xxx/qla_edif.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)