| Message ID | 1651482395-29443-2-git-send-email-quic_rohiagar@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b456b5e7d1df276a4e1050680eec86ccb99d8a82 |
| Headers | show |
| Series | Devicetree updates for Interconnect, USB3 and PHY support | expand |
On 02/05/2022 11:06, Rohit Agarwal wrote: > Add interconnect devicetree nodes in SDX65 platform. > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> > --- > arch/arm/boot/dts/qcom-sdx65.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, May 02, 2022 at 02:36:32PM +0530, Rohit Agarwal wrote: > Add interconnect devicetree nodes in SDX65 platform. > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> > --- > arch/arm/boot/dts/qcom-sdx65.dtsi | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi > index 57bda62..d989837 100644 > --- a/arch/arm/boot/dts/qcom-sdx65.dtsi > +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi > @@ -139,6 +139,26 @@ > status = "disabled"; > }; > > + system_noc: interconnect@1620000 { > + compatible = "qcom,sdx65-system-noc"; > + reg = <0x1620000 0x31200>; > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + mem_noc: interconnect@9680000 { > + compatible = "qcom,sdx65-mem-noc"; > + reg = <0x9680000 0x27200>; > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > + mc_virt: interconnect { If there is no "reg" property then this virtual node should be moved outside of "soc" node. Please refer sm8450.dtsi. Also the rest of the interconnect nodes should be sorted. I know that you are following sdx55, but the nodes were not fully sorted there :/ So please fix it too. Thanks, Mani > + compatible = "qcom,sdx65-mc-virt"; > + #interconnect-cells = <1>; > + qcom,bcm-voters = <&apps_bcm_voter>; > + }; > + > tcsr_mutex: hwlock@1f40000 { > compatible = "qcom,tcsr-mutex"; > reg = <0x01f40000 0x40000>; > @@ -401,6 +421,11 @@ > }; > }; > }; > + > + apps_bcm_voter: bcm-voter { > + compatible = "qcom,bcm-voter"; > + }; > + > }; > }; > > -- > 2.7.4 >
diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi index 57bda62..d989837 100644 --- a/arch/arm/boot/dts/qcom-sdx65.dtsi +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi @@ -139,6 +139,26 @@ status = "disabled"; }; + system_noc: interconnect@1620000 { + compatible = "qcom,sdx65-system-noc"; + reg = <0x1620000 0x31200>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + mem_noc: interconnect@9680000 { + compatible = "qcom,sdx65-mem-noc"; + reg = <0x9680000 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + + mc_virt: interconnect { + compatible = "qcom,sdx65-mc-virt"; + #interconnect-cells = <1>; + qcom,bcm-voters = <&apps_bcm_voter>; + }; + tcsr_mutex: hwlock@1f40000 { compatible = "qcom,tcsr-mutex"; reg = <0x01f40000 0x40000>; @@ -401,6 +421,11 @@ }; }; }; + + apps_bcm_voter: bcm-voter { + compatible = "qcom,bcm-voter"; + }; + }; };
Add interconnect devicetree nodes in SDX65 platform. Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> --- arch/arm/boot/dts/qcom-sdx65.dtsi | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)