Message ID | 20220505063318.296280-5-o.rempel@pengutronix.de (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | add ti dp83td510 support | expand |
On Thu, May 05, 2022 at 08:33:15AM +0200, Oleksij Rempel wrote: > Move baset1 specific part of genphy_c45_read_pma() code to > separate function to make it reusable by PHY drivers. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hi Oleksij, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/add-ti-dp83td510-support/20220505-143922 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4950b6990e3b1efae64a5f6fc5738d25e3b816b3 config: x86_64-randconfig-a016 (https://download.01.org/0day-ci/archive/20220505/202205052146.y8znPT8Q-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e004fb787698440a387750db7f8028e7cb14cfc) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/80dad43edb356876484acb116b8a906dd4bef941 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Oleksij-Rempel/add-ti-dp83td510-support/20220505-143922 git checkout 80dad43edb356876484acb116b8a906dd4bef941 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/phy/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> drivers/net/phy/phy-c45.c:558: warning: expecting prototype for genphy_c45_baset1_read_master_slave(). Prototype was for genphy_c45_pma_baset1_read_master_slave() instead vim +558 drivers/net/phy/phy-c45.c 552 553 /** 554 * genphy_c45_baset1_read_master_slave - read forced master/slave configuration 555 * @phydev: target phy_device struct 556 */ 557 int genphy_c45_pma_baset1_read_master_slave(struct phy_device *phydev) > 558 { 559 int val; 560 561 phydev->master_slave_state = MASTER_SLAVE_STATE_UNKNOWN; 562 563 val = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_PMD_BT1_CTRL); 564 if (val < 0) 565 return val; 566 567 if (val & MDIO_PMA_PMD_BT1_CTRL_CFG_MST) 568 phydev->master_slave_state = MASTER_SLAVE_STATE_MASTER; 569 else 570 phydev->master_slave_state = MASTER_SLAVE_STATE_SLAVE; 571 572 return 0; 573 } 574 EXPORT_SYMBOL_GPL(genphy_c45_pma_baset1_read_master_slave); 575
Hi Oleksij, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/add-ti-dp83td510-support/20220505-143922 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4950b6990e3b1efae64a5f6fc5738d25e3b816b3 config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220506/202205060406.gHnrGdXy-lkp@intel.com/config) compiler: mips-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/80dad43edb356876484acb116b8a906dd4bef941 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Oleksij-Rempel/add-ti-dp83td510-support/20220505-143922 git checkout 80dad43edb356876484acb116b8a906dd4bef941 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/phy/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): >> drivers/net/phy/phy-c45.c:558: warning: expecting prototype for genphy_c45_baset1_read_master_slave(). Prototype was for genphy_c45_pma_baset1_read_master_slave() instead vim +558 drivers/net/phy/phy-c45.c 552 553 /** 554 * genphy_c45_baset1_read_master_slave - read forced master/slave configuration 555 * @phydev: target phy_device struct 556 */ 557 int genphy_c45_pma_baset1_read_master_slave(struct phy_device *phydev) > 558 { 559 int val; 560 561 phydev->master_slave_state = MASTER_SLAVE_STATE_UNKNOWN; 562 563 val = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_PMD_BT1_CTRL); 564 if (val < 0) 565 return val; 566 567 if (val & MDIO_PMA_PMD_BT1_CTRL_CFG_MST) 568 phydev->master_slave_state = MASTER_SLAVE_STATE_MASTER; 569 else 570 phydev->master_slave_state = MASTER_SLAVE_STATE_SLAVE; 571 572 return 0; 573 } 574 EXPORT_SYMBOL_GPL(genphy_c45_pma_baset1_read_master_slave); 575
diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 103a9296bbd0..6f7a03318d42 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -550,6 +550,29 @@ int genphy_c45_read_lpa(struct phy_device *phydev) } EXPORT_SYMBOL_GPL(genphy_c45_read_lpa); +/** + * genphy_c45_baset1_read_master_slave - read forced master/slave configuration + * @phydev: target phy_device struct + */ +int genphy_c45_pma_baset1_read_master_slave(struct phy_device *phydev) +{ + int val; + + phydev->master_slave_state = MASTER_SLAVE_STATE_UNKNOWN; + + val = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_PMD_BT1_CTRL); + if (val < 0) + return val; + + if (val & MDIO_PMA_PMD_BT1_CTRL_CFG_MST) + phydev->master_slave_state = MASTER_SLAVE_STATE_MASTER; + else + phydev->master_slave_state = MASTER_SLAVE_STATE_SLAVE; + + return 0; +} +EXPORT_SYMBOL_GPL(genphy_c45_pma_baset1_read_master_slave); + /** * genphy_c45_read_pma - read link speed etc from PMA * @phydev: target phy_device struct @@ -591,14 +614,9 @@ int genphy_c45_read_pma(struct phy_device *phydev) phydev->duplex = DUPLEX_FULL; if (genphy_c45_baset1_able(phydev)) { - val = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_PMD_BT1_CTRL); + val = genphy_c45_pma_baset1_read_master_slave(phydev); if (val < 0) return val; - - if (MDIO_PMA_PMD_BT1_CTRL_CFG_MST) - phydev->master_slave_state = MASTER_SLAVE_STATE_MASTER; - else - phydev->master_slave_state = MASTER_SLAVE_STATE_SLAVE; } return 0; diff --git a/include/linux/phy.h b/include/linux/phy.h index a8548c138d78..a7490df8e1ec 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1619,6 +1619,7 @@ int genphy_c45_an_config_aneg(struct phy_device *phydev); int genphy_c45_an_disable_aneg(struct phy_device *phydev); int genphy_c45_read_mdix(struct phy_device *phydev); int genphy_c45_pma_read_abilities(struct phy_device *phydev); +int genphy_c45_pma_baset1_read_master_slave(struct phy_device *phydev); int genphy_c45_read_status(struct phy_device *phydev); int genphy_c45_config_aneg(struct phy_device *phydev); int genphy_c45_loopback(struct phy_device *phydev, bool enable);
Move baset1 specific part of genphy_c45_read_pma() code to separate function to make it reusable by PHY drivers. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- drivers/net/phy/phy-c45.c | 30 ++++++++++++++++++++++++------ include/linux/phy.h | 1 + 2 files changed, 25 insertions(+), 6 deletions(-)