diff mbox series

[net-next] net: Make msg_zerocopy_alloc static

Message ID 20220504170947.18773-1-dsahern@kernel.org (mailing list archive)
State Accepted
Commit c67b627e99affe4865b13557d68152ad4c35515c
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net: Make msg_zerocopy_alloc static | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5740 this patch: 5740
netdev/cc_maintainers warning 2 maintainers not CCed: edumazet@google.com imagedong@tencent.com
netdev/build_clang success Errors and warnings before: 1137 this patch: 1137
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 5884 this patch: 5884
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 22 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

David Ahern May 4, 2022, 5:09 p.m. UTC
msg_zerocopy_alloc is only used by msg_zerocopy_realloc; remove the
export and make static in skbuff.c

Signed-off-by: David Ahern <dsahern@kernel.org>
---
 include/linux/skbuff.h | 1 -
 net/core/skbuff.c      | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Jonathan Lemon May 4, 2022, 6:26 p.m. UTC | #1
On Wed, May 04, 2022 at 10:09:47AM -0700, David Ahern wrote:
> msg_zerocopy_alloc is only used by msg_zerocopy_realloc; remove the
> export and make static in skbuff.c
> 
> Signed-off-by: David Ahern <dsahern@kernel.org>

Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
patchwork-bot+netdevbpf@kernel.org May 6, 2022, 1:20 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  4 May 2022 10:09:47 -0700 you wrote:
> msg_zerocopy_alloc is only used by msg_zerocopy_realloc; remove the
> export and make static in skbuff.c
> 
> Signed-off-by: David Ahern <dsahern@kernel.org>
> ---
>  include/linux/skbuff.h | 1 -
>  net/core/skbuff.c      | 3 +--
>  2 files changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
  - [net-next] net: Make msg_zerocopy_alloc static
    https://git.kernel.org/netdev/net-next/c/c67b627e99af

You are awesome, thank you!
diff mbox series

Patch

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 3270cb72e4d8..5c2599e3fe7d 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1665,7 +1665,6 @@  static inline void skb_set_end_offset(struct sk_buff *skb, unsigned int offset)
 }
 #endif
 
-struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size);
 struct ubuf_info *msg_zerocopy_realloc(struct sock *sk, size_t size,
 				       struct ubuf_info *uarg);
 
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 475183f37891..15f7b6f99a8f 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1165,7 +1165,7 @@  void mm_unaccount_pinned_pages(struct mmpin *mmp)
 }
 EXPORT_SYMBOL_GPL(mm_unaccount_pinned_pages);
 
-struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size)
+static struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size)
 {
 	struct ubuf_info *uarg;
 	struct sk_buff *skb;
@@ -1196,7 +1196,6 @@  struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size)
 
 	return uarg;
 }
-EXPORT_SYMBOL_GPL(msg_zerocopy_alloc);
 
 static inline struct sk_buff *skb_from_uarg(struct ubuf_info *uarg)
 {