| Message ID | BY5PR02MB70099A894450D05DC7359CEAD9C59@BY5PR02MB7009.namprd02.prod.outlook.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce EBBG FT8719 DRM panel driver | expand |
On 06/05/2022 14:17, Joel Selvaraj wrote: > Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, > which can be found on some Xiaomi Poco F1 phones. The backlight is > managed through the QCOM WLED driver. > > Signed-off-by: Joel Selvaraj <jo@jsfamily.in> > --- > .../bindings/display/panel/ebbg,ft8719.yaml | 78 +++++++++++++++++++ > 1 file changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml b/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml > new file mode 100644 > index 000000000000..fac6c9692c55 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/ebbg,ft8719.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: EBBG FT8719 MIPI-DSI LCD panel > + > +maintainers: > + - Joel Selvaraj <jo@jsfamily.in> > + > +description: | > + The FT8719 panel from EBBG is a FHD+ LCD display panel with a resolution > + of 1080x2246. It is a video mode DSI panel. The backlight is managed > + through the QCOM WLED driver. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: ebbg,ft8719 > + > + reg: > + description: DSI virtual channel of the peripheral maxItems > + > + reset-gpios: > + description: phandle of gpio for reset line Skip description - it's obvious. > + > + vddio-supply: > + description: phandle of the Power IC supply regulator s/phandle of// > + > + vddpos-supply: > + description: phandle of the positive boost supply regulator > + > + vddneg-supply: > + description: phandle of the negative boost supply regulator > + > + backlight: true > + port: true Both should not be needed - they come from panel-common.yaml. They might stay in list > + > +required: > + - compatible > + - reg > + - vddio-supply > + - vddpos-supply > + - vddneg-supply > + - reset-gpios > + - port > + > +unevaluatedProperties: false > + > +examples: > + - |+ No need for + > + #include <dt-bindings/gpio/gpio.h> > + dsi0 { Just dsi Best regards, Krzysztof
Hi Krzysztof Kozlowski, Thank you for your review. Will fix them in v2. Regards Joel Selvaraj
Hi Krzysztof Kozlowski, A quick question. On 07/05/22 21:02, Krzysztof Kozlowski wrote: >> + backlight: true >> + port: true > > Both should not be needed - they come from panel-common.yaml. They might > stay in list I see that almost 54 panels mention "port: true" and 46 panels mention "backlight: true". Almost all panels refer the panel-common.yaml too. So I think specifying them as true is just for extra clarity that these properties are usually used by this panel? But I am not very sure. Should I leave them be? or it's still recommended to remove them? Best Regards, Joel Selvaraj
On 09/05/2022 07:08, Joel Selvaraj wrote: > Hi Krzysztof Kozlowski, > > A quick question. > > On 07/05/22 21:02, Krzysztof Kozlowski wrote: > >> + backlight: true > >> + port: true > > > > Both should not be needed - they come from panel-common.yaml. They might > > stay in list > > I see that almost 54 panels mention "port: true" and 46 panels mention > "backlight: true". Almost all panels refer the panel-common.yaml too. They need them only if they use "additionalProperties:false". > > So I think specifying them as true is just for extra clarity that > these properties are usually used by this panel? But I am not very sure. If they don't use additionalProperties:false, then the explanation could be: 1. Just for clarity as you say, because they might want to require property/node which is listed in the properties, otherwise it is a bit confusing. 2. They were copying first example without actually checking... > Should I leave them be? or it's still recommended to remove them? It's not a big deal and I do not have strong opinion, but I would propose to remove them from list of properties and still keep port in "required" Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml b/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml new file mode 100644 index 000000000000..fac6c9692c55 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml @@ -0,0 +1,78 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/ebbg,ft8719.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: EBBG FT8719 MIPI-DSI LCD panel + +maintainers: + - Joel Selvaraj <jo@jsfamily.in> + +description: | + The FT8719 panel from EBBG is a FHD+ LCD display panel with a resolution + of 1080x2246. It is a video mode DSI panel. The backlight is managed + through the QCOM WLED driver. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: ebbg,ft8719 + + reg: + description: DSI virtual channel of the peripheral + + reset-gpios: + description: phandle of gpio for reset line + + vddio-supply: + description: phandle of the Power IC supply regulator + + vddpos-supply: + description: phandle of the positive boost supply regulator + + vddneg-supply: + description: phandle of the negative boost supply regulator + + backlight: true + port: true + +required: + - compatible + - reg + - vddio-supply + - vddpos-supply + - vddneg-supply + - reset-gpios + - port + +unevaluatedProperties: false + +examples: + - |+ + #include <dt-bindings/gpio/gpio.h> + dsi0 { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "ebbg,ft8719"; + reg = <0>; + + vddio-supply = <&vreg_l14a_1p88>; + vddpos-supply = <&lab>; + vddneg-supply = <&ibb>; + + reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>; + + backlight = <&pmi8998_wled>; + + port { + ebbg_ft8719_in_0: endpoint { + remote-endpoint = <&dsi0_out>; + }; + }; + }; + };
Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The backlight is managed through the QCOM WLED driver. Signed-off-by: Joel Selvaraj <jo@jsfamily.in> --- .../bindings/display/panel/ebbg,ft8719.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml