diff mbox series

[v4,4/4] KVM: arm64: Reenable pmu in Protected Mode

Message ID 20220510095710.148178-5-tabba@google.com (mailing list archive)
State New, archived
Headers show
Series KVM: arm64: Do not communicate host pmu event changes by accessing hyp data | expand

Commit Message

Fuad Tabba May 10, 2022, 9:57 a.m. UTC
Now that the pmu code does not access hyp data, reenable it in
protected mode.

Once fully supported, protected VMs will not have pmu support,
since that could leak information. However, non-protected VMs in
protected mode should have pmu support if available.

Signed-off-by: Fuad Tabba <tabba@google.com>
---
 arch/arm64/kvm/pmu-emul.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Oliver Upton May 10, 2022, 6:07 p.m. UTC | #1
On Tue, May 10, 2022 at 09:57:10AM +0000, Fuad Tabba wrote:
> Now that the pmu code does not access hyp data, reenable it in
> protected mode.
> 
> Once fully supported, protected VMs will not have pmu support,
> since that could leak information. However, non-protected VMs in
> protected mode should have pmu support if available.
> 
> Signed-off-by: Fuad Tabba <tabba@google.com>

Reviewed-by: Oliver Upton <oupton@google.com>
diff mbox series

Patch

diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c
index 3dc990ac4f44..11c43bed5f97 100644
--- a/arch/arm64/kvm/pmu-emul.c
+++ b/arch/arm64/kvm/pmu-emul.c
@@ -774,8 +774,7 @@  void kvm_host_pmu_init(struct arm_pmu *pmu)
 {
 	struct arm_pmu_entry *entry;
 
-	if (pmu->pmuver == 0 || pmu->pmuver == ID_AA64DFR0_PMUVER_IMP_DEF ||
-	    is_protected_kvm_enabled())
+	if (pmu->pmuver == 0 || pmu->pmuver == ID_AA64DFR0_PMUVER_IMP_DEF)
 		return;
 
 	mutex_lock(&arm_pmus_lock);