diff mbox series

[v9,7/7] MAINTAINERS: add KEYS-TRUSTED-CAAM

Message ID 20220506062553.1068296-8-a.fatoum@pengutronix.de (mailing list archive)
State New
Headers show
Series KEYS: trusted: Introduce support for NXP CAAM-based trusted keys | expand

Commit Message

Ahmad Fatoum May 6, 2022, 6:25 a.m. UTC 
Create a maintainer entry for CAAM trusted keys in the Linux keyring.

Reviewed-by: Pankaj Gupta <pankaj.gupta@nxp.com>
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v8 -> v9:
  - rewrite commit message (Jarkko)
v7 -> v8:
  - add Pankaj's Reviewed-by
v6 -> v7:
  - split off as separate patch (Jarkko)

To: Jarkko Sakkinen <jarkko@kernel.org>
To: James Bottomley <jejb@linux.ibm.com>
To: Mimi Zohar <zohar@linux.ibm.com>
To: David Howells <dhowells@redhat.com>
Cc: James Morris <jmorris@namei.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
Cc: "Horia Geantă" <horia.geanta@nxp.com>
Cc: Pankaj Gupta <pankaj.gupta@nxp.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Biggers <ebiggers@kernel.org>
Cc: Jan Luebbe <j.luebbe@pengutronix.de>
Cc: David Gstir <david@sigma-star.at>
Cc: Richard Weinberger <richard@nod.at>
Cc: Franck LENORMAND <franck.lenormand@nxp.com>
Cc: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Michael Walle <michael@walle.cc>
Cc: Sumit Garg <sumit.garg@linaro.org>
Cc: keyrings@vger.kernel.org
Cc: linux-crypto@vger.kernel.org
Cc: linux-doc@vger.kernel.org
Cc: linux-integrity@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-security-module@vger.kernel.org
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Jarkko Sakkinen May 7, 2022, 7:26 p.m. UTC | #1 
On Fri, May 06, 2022 at 08:25:53AM +0200, Ahmad Fatoum wrote:
> Create a maintainer entry for CAAM trusted keys in the Linux keyring.
> 
> Reviewed-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> v8 -> v9:
>   - rewrite commit message (Jarkko)
> v7 -> v8:
>   - add Pankaj's Reviewed-by
> v6 -> v7:
>   - split off as separate patch (Jarkko)
> 
> To: Jarkko Sakkinen <jarkko@kernel.org>
> To: James Bottomley <jejb@linux.ibm.com>
> To: Mimi Zohar <zohar@linux.ibm.com>
> To: David Howells <dhowells@redhat.com>
> Cc: James Morris <jmorris@namei.org>
> Cc: "Serge E. Hallyn" <serge@hallyn.com>
> Cc: "Horia Geantă" <horia.geanta@nxp.com>
> Cc: Pankaj Gupta <pankaj.gupta@nxp.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Biggers <ebiggers@kernel.org>
> Cc: Jan Luebbe <j.luebbe@pengutronix.de>
> Cc: David Gstir <david@sigma-star.at>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Franck LENORMAND <franck.lenormand@nxp.com>
> Cc: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> Cc: Michael Walle <michael@walle.cc>
> Cc: Sumit Garg <sumit.garg@linaro.org>
> Cc: keyrings@vger.kernel.org
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-doc@vger.kernel.org
> Cc: linux-integrity@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-security-module@vger.kernel.org
> ---
>  MAINTAINERS | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5e8c2f611766..e58e6fc3016d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10855,6 +10855,15 @@ S:	Supported
>  F:	include/keys/trusted_tee.h
>  F:	security/keys/trusted-keys/trusted_tee.c
>  
> +KEYS-TRUSTED-CAAM
> +M:	Ahmad Fatoum <a.fatoum@pengutronix.de>
> +R:	Pengutronix Kernel Team <kernel@pengutronix.de>
> +L:	linux-integrity@vger.kernel.org
> +L:	keyrings@vger.kernel.org
> +S:	Maintained
> +F:	include/keys/trusted_caam.h
> +F:	security/keys/trusted-keys/trusted_caam.c
> +
>  KEYS/KEYRINGS
>  M:	David Howells <dhowells@redhat.com>
>  M:	Jarkko Sakkinen <jarkko@kernel.org>
> -- 
> 2.30.2
> 

Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

BR, Jarkko
Jarkko Sakkinen May 7, 2022, 7:29 p.m. UTC | #2 
On Sat, May 07, 2022 at 10:26:21PM +0300, Jarkko Sakkinen wrote:
> On Fri, May 06, 2022 at 08:25:53AM +0200, Ahmad Fatoum wrote:
> > Create a maintainer entry for CAAM trusted keys in the Linux keyring.
> > 
> > Reviewed-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> > ---
> > v8 -> v9:
> >   - rewrite commit message (Jarkko)
> > v7 -> v8:
> >   - add Pankaj's Reviewed-by
> > v6 -> v7:
> >   - split off as separate patch (Jarkko)
> > 
> > To: Jarkko Sakkinen <jarkko@kernel.org>
> > To: James Bottomley <jejb@linux.ibm.com>
> > To: Mimi Zohar <zohar@linux.ibm.com>
> > To: David Howells <dhowells@redhat.com>
> > Cc: James Morris <jmorris@namei.org>
> > Cc: "Serge E. Hallyn" <serge@hallyn.com>
> > Cc: "Horia Geantă" <horia.geanta@nxp.com>
> > Cc: Pankaj Gupta <pankaj.gupta@nxp.com>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Eric Biggers <ebiggers@kernel.org>
> > Cc: Jan Luebbe <j.luebbe@pengutronix.de>
> > Cc: David Gstir <david@sigma-star.at>
> > Cc: Richard Weinberger <richard@nod.at>
> > Cc: Franck LENORMAND <franck.lenormand@nxp.com>
> > Cc: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> > Cc: Michael Walle <michael@walle.cc>
> > Cc: Sumit Garg <sumit.garg@linaro.org>
> > Cc: keyrings@vger.kernel.org
> > Cc: linux-crypto@vger.kernel.org
> > Cc: linux-doc@vger.kernel.org
> > Cc: linux-integrity@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: linux-security-module@vger.kernel.org
> > ---
> >  MAINTAINERS | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5e8c2f611766..e58e6fc3016d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10855,6 +10855,15 @@ S:	Supported
> >  F:	include/keys/trusted_tee.h
> >  F:	security/keys/trusted-keys/trusted_tee.c
> >  
> > +KEYS-TRUSTED-CAAM
> > +M:	Ahmad Fatoum <a.fatoum@pengutronix.de>
> > +R:	Pengutronix Kernel Team <kernel@pengutronix.de>
> > +L:	linux-integrity@vger.kernel.org
> > +L:	keyrings@vger.kernel.org
> > +S:	Maintained
> > +F:	include/keys/trusted_caam.h
> > +F:	security/keys/trusted-keys/trusted_caam.c
> > +
> >  KEYS/KEYRINGS
> >  M:	David Howells <dhowells@redhat.com>
> >  M:	Jarkko Sakkinen <jarkko@kernel.org>
> > -- 
> > 2.30.2
> > 
> 
> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

3/7 would probably need tested-by. Other than that this starts to look
good...

BR, Jarkko
Ahmad Fatoum May 11, 2022, 10:48 a.m. UTC | #3 
On 07.05.22 21:29, Jarkko Sakkinen wrote:
>>> +KEYS-TRUSTED-CAAM
>>> +M:	Ahmad Fatoum <a.fatoum@pengutronix.de>
>>> +R:	Pengutronix Kernel Team <kernel@pengutronix.de>
>>> +L:	linux-integrity@vger.kernel.org
>>> +L:	keyrings@vger.kernel.org
>>> +S:	Maintained
>>> +F:	include/keys/trusted_caam.h
>>> +F:	security/keys/trusted-keys/trusted_caam.c
>>> +
>>>  KEYS/KEYRINGS
>>>  M:	David Howells <dhowells@redhat.com>
>>>  M:	Jarkko Sakkinen <jarkko@kernel.org>
>>> -- 
>>> 2.30.2
>>>
>>
>> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> 
> 3/7 would probably need tested-by. Other than that this starts to look
> good...

It has been tested by me on an i.MX6 (era < 10 with blobbing support)
and by Michael on a LS1028A (era >= 10, both with and without blobbing
support).

Cheers,
Ahmad

> 
> BR, Jarkko
>
Jarkko Sakkinen May 11, 2022, 3:18 p.m. UTC | #4 
On Wed, May 11, 2022 at 12:48:53PM +0200, Ahmad Fatoum wrote:
> On 07.05.22 21:29, Jarkko Sakkinen wrote:
> >>> +KEYS-TRUSTED-CAAM
> >>> +M:	Ahmad Fatoum <a.fatoum@pengutronix.de>
> >>> +R:	Pengutronix Kernel Team <kernel@pengutronix.de>
> >>> +L:	linux-integrity@vger.kernel.org
> >>> +L:	keyrings@vger.kernel.org
> >>> +S:	Maintained
> >>> +F:	include/keys/trusted_caam.h
> >>> +F:	security/keys/trusted-keys/trusted_caam.c
> >>> +
> >>>  KEYS/KEYRINGS
> >>>  M:	David Howells <dhowells@redhat.com>
> >>>  M:	Jarkko Sakkinen <jarkko@kernel.org>
> >>> -- 
> >>> 2.30.2
> >>>
> >>
> >> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
> > 
> > 3/7 would probably need tested-by. Other than that this starts to look
> > good...
> 
> It has been tested by me on an i.MX6 (era < 10 with blobbing support)
> and by Michael on a LS1028A (era >= 10, both with and without blobbing
> support).
> 
> Cheers,
> Ahmad

Michael, can you give a tested-by for the corresponding patch?

BR, Jarkko
Michael Walle May 11, 2022, 5:13 p.m. UTC | #5 
Am 2022-05-11 17:18, schrieb Jarkko Sakkinen:
> On Wed, May 11, 2022 at 12:48:53PM +0200, Ahmad Fatoum wrote:
>> On 07.05.22 21:29, Jarkko Sakkinen wrote:
>> >>> +KEYS-TRUSTED-CAAM
>> >>> +M:	Ahmad Fatoum <a.fatoum@pengutronix.de>
>> >>> +R:	Pengutronix Kernel Team <kernel@pengutronix.de>
>> >>> +L:	linux-integrity@vger.kernel.org
>> >>> +L:	keyrings@vger.kernel.org
>> >>> +S:	Maintained
>> >>> +F:	include/keys/trusted_caam.h
>> >>> +F:	security/keys/trusted-keys/trusted_caam.c
>> >>> +
>> >>>  KEYS/KEYRINGS
>> >>>  M:	David Howells <dhowells@redhat.com>
>> >>>  M:	Jarkko Sakkinen <jarkko@kernel.org>
>> >>> --
>> >>> 2.30.2
>> >>>
>> >>
>> >> Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
>> >
>> > 3/7 would probably need tested-by. Other than that this starts to look
>> > good...
>> 
>> It has been tested by me on an i.MX6 (era < 10 with blobbing support)
>> and by Michael on a LS1028A (era >= 10, both with and without blobbing
>> support).
>> 
>> Cheers,
>> Ahmad
> 
> Michael, can you give a tested-by for the corresponding patch?

I guess there will be a new version and esp a change of that patch.
I'll retest once the new version is out.

-michael
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 5e8c2f611766..e58e6fc3016d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10855,6 +10855,15 @@  S:	Supported
 F:	include/keys/trusted_tee.h
 F:	security/keys/trusted-keys/trusted_tee.c
 
+KEYS-TRUSTED-CAAM
+M:	Ahmad Fatoum <a.fatoum@pengutronix.de>
+R:	Pengutronix Kernel Team <kernel@pengutronix.de>
+L:	linux-integrity@vger.kernel.org
+L:	keyrings@vger.kernel.org
+S:	Maintained
+F:	include/keys/trusted_caam.h
+F:	security/keys/trusted-keys/trusted_caam.c
+
 KEYS/KEYRINGS
 M:	David Howells <dhowells@redhat.com>
 M:	Jarkko Sakkinen <jarkko@kernel.org>