mbox series

[net,0/3] s390/net: Cleanup some code checker findings

Message ID 20220510070508.334726-1-wintera@linux.ibm.com (mailing list archive)
Headers show
Series s390/net: Cleanup some code checker findings | expand

Message

Alexandra Winter May 10, 2022, 7:05 a.m. UTC 
clean up smatch findings in legacy code. I was not able to provoke
any real failures on my systems, but other hardware reactions,
timing conditions or compiler output, may cause failures.

There are still 2 smatch warnings left in s390/net:

drivers/s390/net/ctcm_main.c:1326 add_channel() warn: missing error code 'rc'
This one is a false positive.

drivers/s390/net/netiucv.c:1355 netiucv_check_user() warn: argument 3 to %02x specifier has type 'char'
Postponing this one, need to better understand string handling in iucv.

There are several sparse warnings left in ctcm, like:
drivers/s390/net/ctcm_fsms.c:573:9: warning: context imbalance in 'ctcm_chx_setmode' - different lock contexts for basic block
Those are mentioned in the source, no plan to rework.

Alexandra Winter (3):
  s390/ctcm: fix variable dereferenced before check
  s390/ctcm: fix potential memory leak
  s390/lcs: fix variable dereferenced before check

 drivers/s390/net/ctcm_mpc.c   | 6 +-----
 drivers/s390/net/ctcm_sysfs.c | 5 +++--
 drivers/s390/net/lcs.c        | 7 ++++---
 3 files changed, 8 insertions(+), 10 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org May 11, 2022, 11:40 a.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 10 May 2022 09:05:05 +0200 you wrote:
> clean up smatch findings in legacy code. I was not able to provoke
> any real failures on my systems, but other hardware reactions,
> timing conditions or compiler output, may cause failures.
> 
> There are still 2 smatch warnings left in s390/net:
> 
> drivers/s390/net/ctcm_main.c:1326 add_channel() warn: missing error code 'rc'
> This one is a false positive.
> 
> [...]

Here is the summary with links:
  - [net,1/3] s390/ctcm: fix variable dereferenced before check
    https://git.kernel.org/netdev/net/c/2c50c6867c85
  - [net,2/3] s390/ctcm: fix potential memory leak
    https://git.kernel.org/netdev/net/c/0c0b20587b9f
  - [net,3/3] s390/lcs: fix variable dereferenced before check
    https://git.kernel.org/netdev/net/c/671bb35c8e74

You are awesome, thank you!