| Message ID | 20220511064920.18455-2-yong.wu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommu/mediatek: Improve safety from dts | expand |
On Wed, May 11, 2022 at 02:49:17PM +0800, Yong Wu wrote: > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE") > Signed-off-by: Yong Wu <yong.wu@mediatek.com> > --- > The Fixes tag commit-id is from linux-next. This is fine. The commit hash will not change unless the maintainer rebases the tree. When maintainers rebase their trees it's their responsibility to deal with the Fixes tags. Often they just fold the fix into the original commit so the issue is moot. Stephen Rothwell checks that Fixes tags point to a valid commit and there are probably other people who have checks for that as well. regards, dan carpenter
Il 11/05/22 08:49, Yong Wu ha scritto: > Mute the probe defer log: > > [ 2.654806] mtk-iommu 14018000.iommu: mm dts parse fail(-517). > [ 2.656168] mtk-iommu 1c01f000.iommu: mm dts parse fail(-517). > > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE") > Signed-off-by: Yong Wu <yong.wu@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Tue, May 10, 2022 at 11:49 PM Yong Wu <yong.wu@mediatek.com> wrote: > > Mute the probe defer log: > > [ 2.654806] mtk-iommu 14018000.iommu: mm dts parse fail(-517). > [ 2.656168] mtk-iommu 1c01f000.iommu: mm dts parse fail(-517). > > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE") > Signed-off-by: Yong Wu <yong.wu@mediatek.com> Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > The Fixes tag commit-id is from linux-next. > --- > drivers/iommu/mtk_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 71b2ace74cd6..0f6ec4a4d9d4 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -1198,7 +1198,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) > if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) { > ret = mtk_iommu_mm_dts_parse(dev, &match, data); > if (ret) { > - dev_err(dev, "mm dts parse fail(%d).", ret); > + dev_err_probe(dev, ret, "mm dts parse fail."); > goto out_runtime_disable; > } > } else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA) && > -- > 2.18.0 >
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 71b2ace74cd6..0f6ec4a4d9d4 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c @@ -1198,7 +1198,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_MM)) { ret = mtk_iommu_mm_dts_parse(dev, &match, data); if (ret) { - dev_err(dev, "mm dts parse fail(%d).", ret); + dev_err_probe(dev, ret, "mm dts parse fail."); goto out_runtime_disable; } } else if (MTK_IOMMU_IS_TYPE(data->plat_data, MTK_IOMMU_TYPE_INFRA) &&
Mute the probe defer log: [ 2.654806] mtk-iommu 14018000.iommu: mm dts parse fail(-517). [ 2.656168] mtk-iommu 1c01f000.iommu: mm dts parse fail(-517). Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE") Signed-off-by: Yong Wu <yong.wu@mediatek.com> --- The Fixes tag commit-id is from linux-next. --- drivers/iommu/mtk_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)