| Message ID | 20220510132637.5864-3-allen-kh.cheng@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: nvmem: mediatek: Convert efuse binding to YAML | expand |
On 10/05/2022 15:26, Allen-KH Cheng wrote: > From: Allen-kh Cheng <allen-kh.cheng@mediatek.corp-partner.google.com> > > We mark mediatek,mt8173-efuse and mediatek,efuse as deprecated to > prevent them from being the single compatible in the future. > > The mediatek,efuse compatible should be used as generic fallback for > all MediaTek chipsets. > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > --- > .../devicetree/bindings/nvmem/mediatek,efuse.yaml | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > index 529f5888d93f..04ecf5980b2e 100644 > --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > @@ -16,16 +16,18 @@ allOf: > properties: > compatible: > oneOf: > - - enum: > - - mediatek,mt8173-efuse > - - mediatek,efuse > + - const: mediatek,mt8173-efuse # Don't use this in new dts files > + deprecated: true > + - const: mediatek,efuse > + deprecated: true > description: > - Only mt8173 SoC-specific compatible with generic fallback should be > - used > + Please use mediatek,efuse as generic fallback to enable the MediaTek > + eFuse support. Now I see the change, it's a bit surprising to have it in separate patch, but ok. In such case, in your first patch don't add this description. There is no point to add a description which immediately you change in next patch. Best regards, Krzysztof
Hi Krzysztof, On Wed, 2022-05-11 at 17:20 +0200, Krzysztof Kozlowski wrote: > On 10/05/2022 15:26, Allen-KH Cheng wrote: > > From: Allen-kh Cheng < > > allen-kh.cheng@mediatek.corp-partner.google.com> > > > > We mark mediatek,mt8173-efuse and mediatek,efuse as deprecated to > > prevent them from being the single compatible in the future. > > > > The mediatek,efuse compatible should be used as generic fallback > > for > > all MediaTek chipsets. > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > --- > > .../devicetree/bindings/nvmem/mediatek,efuse.yaml | 15 +++++++++ > > ------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > > > > diff --git > > a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > > b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > > index 529f5888d93f..04ecf5980b2e 100644 > > --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > > +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml > > @@ -16,16 +16,18 @@ allOf: > > properties: > > compatible: > > oneOf: > > - - enum: > > - - mediatek,mt8173-efuse > > - - mediatek,efuse > > + - const: mediatek,mt8173-efuse # Don't use this in new dts > > files > > + deprecated: true > > + - const: mediatek,efuse > > + deprecated: true > > description: > > - Only mt8173 SoC-specific compatible with generic > > fallback should be > > - used > > + Please use mediatek,efuse as generic fallback to enable > > the MediaTek > > + eFuse support. > > Now I see the change, it's a bit surprising to have it in separate > patch, but ok. In such case, in your first patch don't add this > description. There is no point to add a description which immediately > you change in next patch. > I think I misunderstand "Actually I would prefer to deprecate it in second patch." in preivues reply. It would be great to put all change in one PATCH. On the other hand, in order to not check the same mediatek efuse yaml schema in [1] to cause any conflicts. Chunfeng will integrate with me and resed again in series [1]. [1] https://lore.kernel.org/all/5847417d-921c-7fca-f5de-00e8a550dcb8@linaro.org/ Thanks, Allen > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml index 529f5888d93f..04ecf5980b2e 100644 --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml @@ -16,16 +16,18 @@ allOf: properties: compatible: oneOf: - - enum: - - mediatek,mt8173-efuse - - mediatek,efuse + - const: mediatek,mt8173-efuse # Don't use this in new dts files + deprecated: true + - const: mediatek,efuse + deprecated: true description: - Only mt8173 SoC-specific compatible with generic fallback should be - used + Please use mediatek,efuse as generic fallback to enable the MediaTek + eFuse support. - items: - enum: - mediatek,mt7622-efuse - mediatek,mt7623-efuse + - mediatek,mt8173-efuse - mediatek,mt8183-efuse - mediatek,mt8192-efuse - mediatek,mt8195-efuse @@ -44,7 +46,8 @@ unevaluatedProperties: false examples: - | efuse: efuse@10206000 { - compatible = "mediatek,mt8173-efuse"; + compatible = "mediatek,mt8173-efuse", + "mediatek,efuse"; reg = <0x10206000 0x1000>; #address-cells = <1>; #size-cells = <1>;