diff mbox series

[bpf-next] Enable CONFIG_FPROBE for self tests

Message ID 20220511172249.4082510-1-deso@posteo.net (mailing list archive)
State Accepted
Commit 998e1869de1b10caec6ec940632ff271036926f5
Delegated to: BPF
Headers show
Series [bpf-next] Enable CONFIG_FPROBE for self tests | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for bpf-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 8 maintainers not CCed: netdev@vger.kernel.org kafai@fb.com john.fastabend@gmail.com shuah@kernel.org yhs@fb.com kpsingh@kernel.org linux-kselftest@vger.kernel.org songliubraving@fb.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 4 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-VM_Test-1 fail Logs for Kernel LATEST on ubuntu-latest + selftests
bpf/vmtest-bpf-next-PR fail PR summary
bpf/vmtest-bpf-next-VM_Test-2 success Logs for Kernel LATEST on z15 + selftests

Commit Message

Daniel Müller May 11, 2022, 5:22 p.m. UTC 
Some of the BPF selftests are failing when running with a rather bare
bones configuration based on tools/testing/selftests/bpf/config.
Specifically, we see a bunch of failures due to errno 95:

  > test_attach_api:PASS:fentry_raw_skel_load 0 nsec
  > libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported
  > test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
  > 79 /6     kprobe_multi_test/attach_api_syms:FAIL

The cause of these is that CONFIG_FPROBE is missing. With this change we
add this configuration value to the BPF selftests config.

Signed-off-by: Daniel Müller <deso@posteo.net>
---
 tools/testing/selftests/bpf/config | 1 +
 1 file changed, 1 insertion(+)

Comments

David Vernet May 11, 2022, 5:27 p.m. UTC | #1 
On Wed, May 11, 2022 at 05:22:49PM +0000, Daniel Müller wrote:
> Some of the BPF selftests are failing when running with a rather bare
> bones configuration based on tools/testing/selftests/bpf/config.
> Specifically, we see a bunch of failures due to errno 95:
> 
>   > test_attach_api:PASS:fentry_raw_skel_load 0 nsec
>   > libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported
>   > test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
>   > 79 /6     kprobe_multi_test/attach_api_syms:FAIL
> 
> The cause of these is that CONFIG_FPROBE is missing. With this change we
> add this configuration value to the BPF selftests config.
> 
> Signed-off-by: Daniel Müller <deso@posteo.net>
> ---
>  tools/testing/selftests/bpf/config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
> index 763db6..08c6e5a 100644
> --- a/tools/testing/selftests/bpf/config
> +++ b/tools/testing/selftests/bpf/config
> @@ -53,3 +53,4 @@ CONFIG_NF_DEFRAG_IPV4=y
>  CONFIG_NF_DEFRAG_IPV6=y
>  CONFIG_NF_CONNTRACK=y
>  CONFIG_USERFAULTFD=y
> +CONFIG_FPROBE=y
> -- 
> 2.30.2
> 

Looks good, thanks Daniel.

Acked-by: David Vernet <void@manifault.com>
Alexei Starovoitov May 11, 2022, 7:05 p.m. UTC | #2 
On Wed, May 11, 2022 at 10:23 AM Daniel Müller <deso@posteo.net> wrote:
>
> Some of the BPF selftests are failing when running with a rather bare
> bones configuration based on tools/testing/selftests/bpf/config.
> Specifically, we see a bunch of failures due to errno 95:
>
>   > test_attach_api:PASS:fentry_raw_skel_load 0 nsec
>   > libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported
>   > test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
>   > 79 /6     kprobe_multi_test/attach_api_syms:FAIL
>
> The cause of these is that CONFIG_FPROBE is missing. With this change we
> add this configuration value to the BPF selftests config.
>
> Signed-off-by: Daniel Müller <deso@posteo.net>

Please use 'selftests/bpf: ' prefix in the patch subj
in the future.
I've fixed it up while applying this time.
patchwork-bot+netdevbpf@kernel.org May 11, 2022, 7:10 p.m. UTC | #3 
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 11 May 2022 17:22:49 +0000 you wrote:
> Some of the BPF selftests are failing when running with a rather bare
> bones configuration based on tools/testing/selftests/bpf/config.
> Specifically, we see a bunch of failures due to errno 95:
> 
>   > test_attach_api:PASS:fentry_raw_skel_load 0 nsec
>   > libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported
>   > test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
>   > 79 /6     kprobe_multi_test/attach_api_syms:FAIL
> 
> [...]

Here is the summary with links:
  - [bpf-next] Enable CONFIG_FPROBE for self tests
    https://git.kernel.org/bpf/bpf-next/c/998e1869de1b

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
index 763db6..08c6e5a 100644
--- a/tools/testing/selftests/bpf/config
+++ b/tools/testing/selftests/bpf/config
@@ -53,3 +53,4 @@  CONFIG_NF_DEFRAG_IPV4=y
 CONFIG_NF_DEFRAG_IPV6=y
 CONFIG_NF_CONNTRACK=y
 CONFIG_USERFAULTFD=y
+CONFIG_FPROBE=y